Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD/CI: 3.9 support #36296

Closed
1 of 2 tasks
jreback opened this issue Sep 11, 2020 · 14 comments · Fixed by #36393
Closed
1 of 2 tasks

BLD/CI: 3.9 support #36296

jreback opened this issue Sep 11, 2020 · 14 comments · Fixed by #36393
Labels
Build Library building on various platforms CI Continuous Integration
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Sep 11, 2020

  • CI for the 3.9 build is from source, we should update this to use numpy wheels (just became available IIUC) CI: install numpy from pip #36296 #36323
  • pass tests & update whatsnew for 3.9 build so we can include in 1.1.3

cc @pandas-dev/pandas-core

@jreback jreback added Build Library building on various platforms CI Continuous Integration labels Sep 11, 2020
@jreback jreback added this to the 1.1.3 milestone Sep 11, 2020
@fangchenli
Copy link
Member

fangchenli commented Sep 12, 2020

We need to fix #34014. It won't compile right now.

@jbrockmendel
Copy link
Member

AFAICT #34014 is fixed by #35928 + #34997

@wumpus
Copy link

wumpus commented Sep 13, 2020

Also #36298 is needed to build with -Werror on 3.9 -- I haven't run the pandas test suite with it, but it did fix pandas enough that my pandas-using project was happy in with 3.9 in travisci

@TomAugspurger
Copy link
Contributor

@jbrockmendel how comfortable are you with backporting #34997 and #35928? IMO those probably decide whether we're likely to add support for Pytyhon 3.9 in 1.1.x or 1.2.0.

@simonjayhawkins
Copy link
Member

1.1.x still needs to support 3.6. so need to make sure any changes to don't break 3.6 support.

@jbrockmendel
Copy link
Member

how comfortable are you with backporting #34997 and #35928? IMO those probably decide whether we're likely to add support for Pytyhon 3.9 in 1.1.x or 1.2.0.

no particular objections

@jorisvandenbossche
Copy link
Member

I am not sure #34997 is a good one to backport, it involve quite some tricky code / corner cases?

@jreback
Copy link
Contributor Author

jreback commented Sep 15, 2020

what do we actually need to support 3.9 in 1.1.3? the above PRs are nice to have for cython3 but don't appear to actually be needed correct? (exempting #36298)

@jreback
Copy link
Contributor Author

jreback commented Sep 15, 2020

do we actually need cython3 to compile for 3.9? e.g. https://travis-ci.org/github/pandas-dev/pandas/jobs/726742374

@wumpus
Copy link

wumpus commented Sep 16, 2020

See my 3 day old comment for a report of exactly what I needed to build with 3.9

Also #36298 is needed to build with -Werror on 3.9 -- I haven't run the pandas test suite with it, but it did fix pandas enough that my pandas-using project was happy in with 3.9 in travisci

Just 2 lines of change plus cython3.

@jbrockmendel
Copy link
Member

Just 2 lines of change plus cython3.

The reason why @jreback is asking is because there are two difficulties with bumping to cython3: 1) it isn't actually released yet and 2) bumping to it breaks a bunch of our tests, the fixes for which are not easy.

So the question is if there is any option that doesnt require cy3.

@jreback
Copy link
Contributor Author

jreback commented Sep 16, 2020

numpy is building with 29.21: https://github.com/numpy/numpy/releases/tag/v1.19.2

can try removing the -pre here: https://github.com/pandas-dev/pandas/blob/master/ci/build39.sh#L7

and see what happens

@fangchenli
Copy link
Member

fangchenli commented Sep 16, 2020

numpy is building with 29.21: https://github.com/numpy/numpy/releases/tag/v1.19.2

can try removing the -pre here: https://github.com/pandas-dev/pandas/blob/master/ci/build39.sh#L7

and see what happens

I just tried this. We only need #36298 + remove --pre to make it work. And all tests passed on my machine (without optional dependencies).

@jreback
Copy link
Contributor Author

jreback commented Sep 16, 2020

wow let's do it (single PR wouos be great as have to backport)

also can i update .travis.yml to make this a build that is required (remove the allow failures for that one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants