Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale Bot for Old Issues and PR's? #23489

Closed
gfyoung opened this issue Nov 4, 2018 · 8 comments
Closed

Stale Bot for Old Issues and PR's? #23489

gfyoung opened this issue Nov 4, 2018 · 8 comments
Labels
Admin Administrative tasks related to the pandas project

Comments

@gfyoung
Copy link
Member

gfyoung commented Nov 4, 2018

https://probot.github.io/apps/stale/

cc @pandas-dev/pandas-core

(looking at you @jreback in particular, given the herculean task you periodically undertake of closing and pinging stale PR's for further work or rebasing)

xref PR Management Email Chain (internal)

@gfyoung gfyoung added the Admin Administrative tasks related to the pandas project label Nov 4, 2018
@alimcmaster1
Copy link
Member

+1 for something like this!

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Nov 4, 2018 via email

@alimcmaster1
Copy link
Member

@TomAugspurger looking at the docs it can be limited to just PRs with something like:

# Limit to only `issues` or `pulls`
# only: pulls

@datapythonista
Copy link
Member

I'm -1 on this. For the PRs labeled with "Docs" or "Style" (around one quarter of the total), the ones I usually monitor, I wouldn't like any bot to label them as stale or close it. The ones I think they are worth closing it doesn't give me any work to close. And it'd be annoying to have to reopen soon (there are many old ones that there is work going on, or I want to finish myself).

@jreback
Copy link
Contributor

jreback commented Nov 4, 2018

we could configure this to act in a limited fashion
though in reaity just having folks go thru older PRs occasionally is enough

@alimcmaster1
Copy link
Member

Another potential option out there is gitmate which has features like automatic label setting and finding duplicate issues - I don't have any first hand experience of using it -but could potentially be useful.

@gfyoung
Copy link
Member Author

gfyoung commented Nov 4, 2018

In response to many of the comments, I agree with @jreback that we can use it in a limited fashion. For starters, there is a lag between when the bot adds the stale label and when it closes the PR. Thus, if you are concerned about getting things auto-closed, you can delay the closing for some time.

@datapythonista : I think that would address your concern of having to constantly reopen them, as the bot would not close the PR for awhile but we would still get the advantage of pinging people.

@gfyoung
Copy link
Member Author

gfyoung commented Nov 7, 2018

Given the pushback, I'll close this. Perhaps another day, another time. 🙂

@gfyoung gfyoung closed this as completed Nov 7, 2018
@gfyoung gfyoung added this to the No action milestone Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Administrative tasks related to the pandas project
Projects
None yet
Development

No branches or pull requests

5 participants