Skip to content

Commit

Permalink
fix pyarrow issue
Browse files Browse the repository at this point in the history
  • Loading branch information
topper-123 committed Nov 25, 2020
1 parent 3929828 commit 122a6fe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion doc/source/whatsnew/v1.2.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,6 @@ ExtensionArray
- Fixed an inconsistency in :class:`.PeriodArray`'s ``__init__`` signature to those of :class:`.DatetimeArray` and :class:`.TimedeltaArray` (:issue:`37289`)
- Reductions for :class:`.BooleanArray`, :class:`.Categorical`, :class:`.DatetimeArray`, :class:`.FloatingArray`, :class:`.IntegerArray`, :class:`.PeriodArray`, :class:`.TimedeltaArray`, and :class:`.PandasArray` are now keyword-only methods (:issue:`37541`)
- Fixed a bug where a `ValueError` was wrongly raised if a membership check was made on an `ExtensionArray` containing nan-like values (:issue:`37867`)
- Bug, where a `ValueError` was wrongly raised if a membership check was made on an `ExtensionArray` with :class:`NA` values, but without a custom ``__contains__`` method (:issue:`37867`)

Other
^^^^^
Expand Down
5 changes: 3 additions & 2 deletions pandas/tests/extension/base/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,15 @@ def test_contains(self, data):
assert scalar in data

na_value = data.dtype.na_value
other_na_value_types = {None, np.nan, pd.NA, pd.NaT}.difference({na_value})

if data.isna().any():
assert na_value in data
else:
assert na_value not in data

for na_value_type in other_na_value_types:
for na_value_type in {None, np.nan, pd.NA, pd.NaT}:
if na_value_type is na_value:
continue
assert na_value_type not in data

def test_memory_usage(self, data):
Expand Down

0 comments on commit 122a6fe

Please sign in to comment.