Skip to content

Commit

Permalink
fix #28926 pandas\api\test_api.py mypy errors (#28935)
Browse files Browse the repository at this point in the history
*  fix #28926 pandas\api\test_api.py mypy errors

*  fix #28926 pandas\api\test_api.py mypy errors

*  changed to  type comment to support v 3.5

* removed section mypy-pandas.tests.api.test_api

* fix annotation and revert delete

* fix import sorting

* fix import sorting
  • Loading branch information
yogendrasoni authored and WillAyd committed Oct 13, 2019
1 parent 2931f02 commit 04d7931
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
12 changes: 7 additions & 5 deletions pandas/tests/api/test_api.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from typing import List

import pandas as pd
from pandas import api, compat
from pandas.util import testing as tm
Expand Down Expand Up @@ -41,7 +43,7 @@ class TestPDApi(Base):
]

# these are already deprecated; awaiting removal
deprecated_modules = []
deprecated_modules = [] # type: List[str]

# misc
misc = ["IndexSlice", "NaT"]
Expand Down Expand Up @@ -92,10 +94,10 @@ class TestPDApi(Base):
classes.extend(["Panel", "SparseSeries", "SparseDataFrame"])

# these are already deprecated; awaiting removal
deprecated_classes = []
deprecated_classes = [] # type: List[str]

# these should be deprecated in the future
deprecated_classes_in_future = []
deprecated_classes_in_future = [] # type: List[str]

# external modules exposed in pandas namespace
modules = ["np", "datetime"]
Expand Down Expand Up @@ -171,10 +173,10 @@ class TestPDApi(Base):
funcs_to = ["to_datetime", "to_msgpack", "to_numeric", "to_pickle", "to_timedelta"]

# top-level to deprecate in the future
deprecated_funcs_in_future = []
deprecated_funcs_in_future = [] # type: List[str]

# these are already deprecated; awaiting removal
deprecated_funcs = []
deprecated_funcs = [] # type: List[str]

# private modules in pandas namespace
private_modules = [
Expand Down
3 changes: 0 additions & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ no_implicit_optional=True
[mypy-pandas.conftest]
ignore_errors=True

[mypy-pandas.tests.api.test_api]
ignore_errors=True

[mypy-pandas.tests.arithmetic.test_datetime64]
ignore_errors=True

Expand Down

0 comments on commit 04d7931

Please sign in to comment.