Remove deprecated arguments and functions #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas-stubs/core/frame.pyi # pandas-stubs/core/generic.pyi # pandas-stubs/core/groupby/groupby.pyi # pandas-stubs/core/indexes/datetimes.pyi # pandas-stubs/core/indexes/timedeltas.pyi # pandas-stubs/core/resample.pyi # pandas-stubs/core/series.pyi # pandas-stubs/core/window/rolling.pyi # pandas-stubs/io/formats/style.pyi # pandas-stubs/io/parsers.pyi # tests/test_pandas.py
Dr-Irv
reviewed
Sep 17, 2022
| @@ -15,6 +15,7 @@ from pandas._typing import ( | |||
|
|
|||
| def read_xml( | |||
| path_or_buffer: FilePath | ReadBuffer[bytes] | ReadBuffer[str], | |||
| *, | |||
There was a problem hiding this comment.
Not clear why you added this??
There was a problem hiding this comment.
We deprecated passing positional arguments to read_xml in 1.4
Deprecated passing arguments as positional for read_xml() other than path_or_buffer (GH45133)
There was a problem hiding this comment.
OK, the docs don't say anything about that, so maybe the docs should be updated as well.
There was a problem hiding this comment.
I think we are not mentioning positional deprecations in the docs
|
Opened pandas-dev/pandas#48599 to add deprecation flags in the docs |
Dr-Irv
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valueThis is for the 1.4 deprecations