<WIP> feat: set reserveOf transient #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So now we use sync, the excess tokens be burned ? |
do you mean the case when someone else randomly send erc20 token to the vault? If so, then yes, those tokens are burned now if this PR is merged. |
ChefSnoopy
previously approved these changes
May 6, 2024
Comment on lines
+44
to
+48
| assembly { | ||
| mstore(0x0, slot) | ||
| mstore(0x20, currency) | ||
| key := keccak256(0x0, 0x40) | ||
| } |
There was a problem hiding this comment.
just curious, why not keccak256(abi.encodePacked(slot, currency.unwrap())) ?
There was a problem hiding this comment.
mostly around gas savings, can see CLPosition and BinPosition using similar technique.
Merged
|
now the latest test snapshot would be more accurate. though some test are failing and have comment out for now. likely this PR can serve as reference for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a POC on setting
reserveOfas transient.Context
user flow to v4-core would change from
erc20.transfer(vault, amt) -> vault.settle()tovault.sync() -> erc20.transfer(vault, amt) -> vault.settle()as
reservesOfare already tracked inreserveOfPoolManager,reserveOfis now transient. This should still be secured in the sense that CLPoolManager cannot take BinPoolManager assetThis also remove the need for
settleAndMintRefund()due to async(currency)which set the current erc20 balancethis should save gas however the snapshot might not show this case (see below)
Why gas snapshot doesn't show this case ?
forge testwhere we should useforge test --isolateto run each statement as a new transaction. In this case we can see the clear benefit of transient storageDiscussion:
forge test --isolateandsnapLastCall()and merge then update this branch and we can see clear gas benefitreserveOfcheck or move toerc20.balanceOf(vault)lockWithSync(bytes calldata data, Currency[] currency)which gets a lock() and sync() those currency