fix: add onlyRegisteredApp for Vault.collectFee #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
reviewed
Jul 2, 2024
| @@ -157,7 +157,7 @@ contract Vault is IVault, VaultToken, Ownable { | |||
| } | |||
|
|
|||
| /// @inheritdoc IVault | |||
| function collectFee(Currency currency, uint256 amount, address recipient) external { | |||
| function collectFee(Currency currency, uint256 amount, address recipient) external onlyRegisteredApp { | |||
There was a problem hiding this comment.
might be good to add a test to check if theres revert if called by non registered app
There was a problem hiding this comment.
yeah, there is already that check. can see the test case i updated below
ChefMist
previously approved these changes
Jul 2, 2024
chefburger
force-pushed
the
fix/add-onlyRegisteredApp-for-collectFee
branch
from
b1f0436
to
54f6c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104