Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README.md #1

wants to merge 2 commits into from

Conversation

jeetsons
Copy link

Update the readme.

ChefMist
ChefMist reviewed Mar 19, 2024
View reviewed changes
README.md
forge script script/01_DeployVault.s.sol:DeployVaultScript -vvv \
--rpc-url $RPC_URL \
--broadcast \
--slow \
--verify
```

Note you will need to update the `script/config/xxx.json` file to set the vault address that was created in order to deploy the PoolManagers.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for raisng PR. Would you mind removing this line?

Thinking of placing this line within the deployment script as each script would have different pre-requisite note. thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

تع

cyuxhtby added a commit to cyuxhtby/pancake-v4-core that referenced this pull request Jul 22, 2024
@cyuxhtby
pancakeswap#1 - architecture & flash accounting
ac93944
Uzoke22
Uzoke22 approved these changes Sep 14, 2024
View reviewed changes
Copy link

@Uzoke22 Uzoke22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChefMist ChefMist ChefMist left review comments

@ahmed1106666 ahmed1106666 ahmed1106666 left review comments

@cynthiaa14pohfletcher cynthiaa14pohfletcher cynthiaa14pohfletcher approved these changes

@Uzoke22 Uzoke22 Uzoke22 approved these changes

@Brkoslav04 Brkoslav04 Brkoslav04 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeetsons @cynthiaa14pohfletcher @ChefMist @Uzoke22 @Brkoslav04 @ahmed1106666 @tomafc330