Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove project name validation #741

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Remove project name validation #741

merged 2 commits into from
Feb 9, 2024

Conversation

pkoenig10
Copy link
Member

The project name validation no longer matches the Docker Compose behaivor.

docker/compose#5788

Docker Compose will normalize project names if they do not conform to it's requirements.

This is better for consumers because it means they can use the same project names in tests and when running Docker Compose manually.

@changelog-app
Copy link

changelog-app bot commented Feb 9, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Project names are no longer validation. Any value can be used for a project name.

Check the box to generate changelog(s)

  • Generate changelog entry

@pkoenig10
Copy link
Member Author

I know this project is old. But we still use it in some legacy tests internally and relaxing this validation would be help us out.

@bulldozer-bot bulldozer-bot bot merged commit 2e999cb into master Feb 9, 2024
10 checks passed
@bulldozer-bot bulldozer-bot bot deleted the pkoenig/projectName branch February 9, 2024 12:09
@svc-autorelease
Copy link
Collaborator

Released 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants