Added empty add-on.css and add-on.js files and extended the documenta… #88
Conversation
…tion to explain their purpose.
|
We are actually moving away from using the |
|
@pacollins Even though it turns out that none of the three changed files in this PR suits (the development of) our theme, @twatzl does spot out a usability problem that affects every user, and he has made efforts to improve this. Judging from the code written, that would suppress the error message in #87. Despite we're not going to adopt the code, the linked issue surely qualifies a contribution to our theme. As a result, I would like to grant him the status of "Contributor" without actually using the code here. If you agree, I would made some edits (remove |
|
I'm fine with getting him in the commit history. :)
…On Sun, Aug 25, 2019, 9:12 PM Vincent Tam ***@***.***> wrote:
@pacollins <https://github.com/pacollins> Even though it turns out that
none of the three changed files in this PR suits (the development of) our
theme, @twatzl <https://github.com/twatzl> does spot out a usability
problem that affects every user, and he has made efforts to improve this.
Judging from the code written, that would suppress the error message in
#87 <#87>.
Despite we're not going to adopt the code, the linked issue surely
qualifies a contribution to our theme.
As a result, I would like to grant him the status of "Contributor" without
actually using the code here. If you agree, I would made some edits (remove
static/*/add-on.*, edit README?) on top of this PR, before merging this
against the remove-cdn branch. In this way, the Git commit object in this
PR would appear in the Git history of the remove-cdn branch, so that
@twatzl <https://github.com/twatzl> would become a "Contributor" to our
theme upon the merging of #66
<#66>, which
is very likely to happen in a few days/weeks. We could proceed to closing
this PR once the merging would be done.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88?email_source=notifications&email_token=ACWVJSLQRXH7Q5XAP32H63LQGMUXFA5CNFSM4IPKUEKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DAFSQ#issuecomment-524681930>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWVJSJMWE5VBVQRSA4BXILQGMUXFANCNFSM4IPKUEKA>
.
|
@pacollins Done at the recent merge commit commits of #66. |
I have noticed that
add-on.jsandadd-on.cssare missing from the theme. I copied the files which existed already in the example site and expanded README.md to better explain their purpose.