Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Enable custom Staticman endpoint #31

Merged
merged 6 commits into from
Jul 5, 2019
Merged

Conversation

VincentTam
Copy link
Collaborator

@VincentTam VincentTam commented Jul 4, 2019

Description

Fix #28 and close #29.

EDIT: Also closes #21 - PC

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

layouts/post/staticman.html Outdated Show resolved Hide resolved
layouts/post/staticman.html Outdated Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

layouts/post/staticman.html Show resolved Hide resolved
Copy link
Collaborator Author

@VincentTam VincentTam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test GitHub's review functionality.

  1. Improved v3 support
  2. Replaced deprecated Hugo syntax

@pacollins
Copy link
Owner

Man, that is the first time that bot has be used. It is ruthless. Haha, I will review this soon.

@VincentTam
Copy link
Collaborator Author

Perhaps it would be helpful to show GitLab CI's output to verify .UniqueID.File.UniqueID.

@pacollins
Copy link
Owner

On my end everything works except reCAPTCHA. Is there anything special - is it reCAPTCHA v3?

{"success":false,"message":"reCAPTCHA: The response parameter is invalid or malformed","rawError":{"_smErrorCode":"invalid-input-response"},"errorCode":"RECAPTCHA_INVALID_INPUT_RESPONSE"}

@VincentTam
Copy link
Collaborator Author

Overall speaking, I've not touched your code about reCAPTCHA v3, which I've never tried, so I can't comment. Btw, this PR is meant to be an analogue of mmistakes/minimal-mistakes#1845, and the Go-HTML code in this PR does its work of getting the site config parameters into the generate HTML pages. reCAPTCHA is another issue.

@pacollins
Copy link
Owner

I see now. I will just need to revert to reCAPTCHA v2.

Thanks for all of this.

@pacollins pacollins merged commit e26d9f3 into pacollins:master Jul 5, 2019
@VincentTam
Copy link
Collaborator Author

👍 for the merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Support custom Git service provider BUG: Incorrect Staticman v3 form URL
2 participants