Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Some changes to layout and CSS #102

Closed
wants to merge 3 commits into from

Conversation

samiaab1990
Copy link

@samiaab1990 samiaab1990 commented Nov 5, 2019

Description

A few changes I had in mind as I worked with this theme

  • One, I added <style> to the class of mini-posts and background color from there. Although I realize adding the styling to the html file is less preferred than making changes to the CSS, I tried modifying the background color with the CSS and also troubleshooted with the code to see if I can get the desired color in CSS. Did not work.
  • The other is adding a class to the images in layouts-->post-->featured and putting that class in the css file. The images can be really big on the posts so this allows for the option to resize them.
    -In the same file, I added a with {{ .Params.caption}} to allow figure captions in the YAML. The font, text, etc. can be edited in the css as it is set to class="caption"

Motivation and Context

-For the <style> to the mini-posts, my motivation is that it allows styling of the mini-post that the CSS is not allowing
-For the image/image caption, it allows for resizing of the post image and an added option to caption the images

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

TMineCola and others added 3 commits November 4, 2019 21:40
… sheet <article class="mini-post" (although CSS is supposed to do the styling, that-did not work)
…ng captions with the images. Added a class to the post images and captions and option to style attributes on css
@samiaab1990 samiaab1990 changed the title Put <style> in article class mini-post to make styling changes Some changes to layout and CSS Nov 5, 2019
@pacollins
Copy link
Owner

Thanks for your PR and wanting to help with theme development!

Just as a git common practice, try to avoid doing multiple features (unless directly related) into the same PR.

For CSS adjustments, you should really include screenshots so we can quickly see the change. Also, style="" is not valid for HTML5, so we won't include that. There is an issue with add-on.css from #87 that got stalled from #66.

Just as a heads up, both of the main maintainers of this theme just got back to work this fall and are swamped. We are still facilitating PRs from contributors, but our personal contributions are slim at the moment.

@samiaab1990
Copy link
Author

Thanks for your PR and wanting to help with theme development!

Just as a git common practice, try to avoid doing multiple features (unless directly related) into the same PR.

For CSS adjustments, you should really include screenshots so we can quickly see the change. Also, style="" is not valid for HTML5, so we won't include that. There is an issue with add-on.css from #87 that got stalled from #66.

Just as a heads up, both of the main maintainers of this theme just got back to work this fall and are swamped. We are still facilitating PRs from contributors, but our personal contributions are slim at the moment.

Hi, no problem! Thank you for your response and sorry about that. I was able to figure out the problems I had. I will follow up with an example of what worked on my add-on css vs the format of the main.scss that I copied on my add-on which wasn't working for me.

Also I added a dark mode button to my theme which I think would be a nice feature for the main theme as well.

@pacollins
Copy link
Owner

Closing this PR, but very interested in your dark mode button - feel free to make a PR.

@pacollins pacollins closed this Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants