escape domain regexes #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds-cbo
commented
Jan 5, 2024
| r"https?://codeload.github.com/(?P<namespace>.+)/(?P<name>.+)/" | ||
| r"(zip|tar.gz|tar.bz2|tgz)/(.*/)*" | ||
| r"https?://codeload\.github\.com/(?P<namespace>.+)/(?P<name>.+)/" | ||
| r"(zip|tar\.gz|tar\.bz2|tgz)/([^/]*/)*" |
There was a problem hiding this comment.
Reason for this change from (.*/)* to ([^/]*/)* can be found here:
https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS
ds-cbo
commented
Jan 5, 2024
| r"((?P=name)(-|@)?)?" | ||
| r"(?P<version_prefix>v|V?)(?P<version>.+).(zip|tar.gz|tar.bz2|.tgz)" | ||
| r"(?P<version_prefix>v|V?)(?P<version>.+)\.(zip|tar\.gz|tar\.bz2|tgz)" |
There was a problem hiding this comment.
This also fixes a bug with tgz files, since it would previously match
v1.2.3.tgz as { version="1.2.", extension=".tgz" }
as opposed to { version="1.2.3", extension="tgz" }
due to the double unescaped . here.
See for clarification: https://regex101.com/r/luaRIy/1
|
Thanks! do you mind to resolve the conflicts that emerged since so we can merge? |
|
@pombredanne I've resolved the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140