Golang support #113
Open
Golang support #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
jasinner
reviewed
Feb 21, 2023
| # https://stackoverflow.com/questions/57355929/what-does-incompatible-in-go-mod-mean-will-it-cause-harm | ||
| if "-" in purl_data.version: | ||
| version = purl_data.version.split("-") | ||
| if exp.match(purl_data.name): |
There was a problem hiding this comment.
What's the point of this check? Do go package names sometimes have v[0-9]+ in them? Why do we use the name in the download_url in that case?
There was a problem hiding this comment.
Maybe this check should actually be:
if len(namespace) >= 3:
There was a problem hiding this comment.
Oh, perhaps this check is looking for modules with backward incompatiable changes as explained here: https://go.dev/doc/modules/release-workflow
There was a problem hiding this comment.
Maybe the checks could instead be replaced by:
if len(namespace_parts) == 2:
return (
f"https://{namespace_parts[0]}/{namespace_parts[1]}/{purl_data.name}"
f"/tree/{version}"
)
else:
return (
f"https://{namespace_parts[0]}/{namespace_parts[1]}/{namespace_parts[2]}"
f"/tree/{version}"
)
I don't see the need for the regular expression check because the backwards incompatiable changes always occur at the 3rd portion of the namespace anyway right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very basic implementation for golang support. Supports most of the golang purls what I tested with, but not perfect.