fix: address decodeURIComponent errors #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-phylum
reviewed
Aug 20, 2024
jdalton
force-pushed
the
jdalton/decode-error
branch
from
3bf1f9c
to
4c3bf8c
Compare
jdalton
force-pushed
the
jdalton/decode-error
branch
from
4c3bf8c
to
b17f575
Compare
matt-phylum
approved these changes
Aug 23, 2024
| function decodeURIComponent(encodedURIComponent) { | ||
| try { | ||
| return decodeURIComponent_(encodedURIComponent) | ||
| } catch {} |
There was a problem hiding this comment.
I'm a little worried about this. If somebody writes pkg:generic/whatever#100% it will do what they want, but if somebody writes pkg:generic/whatever#100%/100%25, the subpath will be 100%/100%25 because the decoding error applies to the entire component.
Implementations are inconsistent.
- error: anchore/packageurl-go, package-url/packageurl-go, package-url/packageurl-java, package-url/packageurl-js (2.0.0), sonatype/package-url-java
- 100%/100%: althonos/packageurl.rs, giterlizzi/perl-URL-PackageURL, package-url/packageurl-dotnet, package-url/packageurl-php, package-url/packageurl-python, package-url/packageurl-swift, phylum-dev/purl
- 100%/100%25: maennchen/purl, package-url/packageurl-ruby, package-url/packageurl-js (this code)
It probably doesn't matter because it's an invalid PURL to begin with.
There was a problem hiding this comment.
@matt-phylum Thank you for digging into this. It is interesting.
new URL('pkg:generic/whatever#100%/100%25').toString()
// -> 'pkg:generic/whatever#100%/100%25'While
PackageURL.fromString('pkg:generic/whatever#100%/100%25').toString()
-> 'pkg:generic/whatever#100%25/100%2525'Updated PR to error:
PurlError: Invalid purl: unable to decode "subpath" component
ab2f960
to
6dd4e51
Compare
steven-esser
approved these changes
Aug 27, 2024
|
@steven-esser could you cut a patch release at your convenience 🙏 |
|
@jdalton Will do |
|
@jdalton |
|
Thank you @steven-esser 🕺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address #75.
I'm still noodling on normalization behavior of the constructor. We may be able to tweak it to howURLSearchParamsdoes it (it must have some encoding detection).Update:
After reviewing
new URL(), andnew URLSearchParams()we can avoiddecodeURIComponentduring normalization and only use it inparseString.