feat: narrow types and optimize #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalton
force-pushed
the
jdalton/type-nits
branch
3 times, most recently
from
b8db8b5
to
e30fd95
Compare
jdalton
force-pushed
the
jdalton/type-nits
branch
from
e30fd95
to
6578e8a
Compare
|
BTW in the meantime I'm maintaining a fork @jdalton/packageurl-js at https://github.com/jdalton/packageurl-js/tree/jdalton/fork that has all open issues resolved. |
|
@jdalton Thanks for the PR. Sorry about the lack of response in this repo, I have been busy with work and family life. I should be a bit more active now and will handle updating the repo with the various fixes in flight. |
steven-esser
approved these changes
May 17, 2024
No worries. I totally get it (I'm in a similar boat). I'm trickling in PRs for ya. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR narrows the result types from
string | undefined | nulltostring | undefinedwhile still acceptingnulls. It also optimizes things a bit.