Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong-name the assemblies #9

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Jan 11, 2022

Fixes #8

I generated the snk file simply by running sn -k StrongName.snk.

I also added a pretty basic Directory.Build.props and Directory.Build.rsp

@dfederm
Copy link
Contributor Author

dfederm commented Jan 11, 2022

CC @am11 @ThomasPiskol @JamieMagee

@dfederm
Copy link
Contributor Author

dfederm commented Jan 12, 2022

@ThomasPiskol since you have maintainer access now (yay!), mind taking a look? My hope is to get this merged, pushed to NuGet.org, and integrated downstream by EOW :)

Copy link
Collaborator

@ThomasPiskol ThomasPiskol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my point of view. 👍

@ThomasPiskol ThomasPiskol merged commit 183c1a9 into package-url:master Jan 12, 2022
@ThomasPiskol
Copy link
Collaborator

My hope is to get this merged, pushed to NuGet.org, and integrated downstream by EOW :)

I'll integrate the changes in my PR, so let's see if we can let your wish come true 🙂

@dfederm dfederm deleted the strong-naming branch January 12, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly does not have a strong name
2 participants