Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct syntax for environment variable #11

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

ThomasPiskol
Copy link
Collaborator

Fixes the upload issue due to missing API key because of wrong syntax.

@ThomasPiskol
Copy link
Collaborator Author

@am11 That should fix the issue with token which you have faced.

Copy link
Collaborator

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@am11 am11 merged commit 5c27400 into package-url:master Feb 26, 2022
@am11
Copy link
Collaborator

am11 commented Feb 26, 2022

Ah, it failed again: https://github.com/package-url/packageurl-dotnet/runs/5346177918
Perhaps the key which was added in repository secrets is incorrect?

@ThomasPiskol
Copy link
Collaborator Author

Ok, it seems that this time it's not issue with token or the script.

There's already an existing NuGet package with the same ID available on nuget.org: https://www.nuget.org/packages/PackageUrl/

Due to the existing package we cannot publish our own package.
So we can either ask the owner of the existing package to remove his version and transfer the ownership of this package ID to us. But I'm not sure if it's possible to transfer the ownership of an existing Package ID on NuGet.org at all.

The other option I see is to change our package ID (currently PackageUrl) to something else (e.g. packageurl-dotnet)

@ThomasPiskol
Copy link
Collaborator Author

@am11 I've created an issue: #12 let's continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants