Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cube in Calculator.java #78

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding cube in Calculator.java #78

wants to merge 5 commits into from

Conversation

PriscaTan
Copy link

No description provided.

@pH-7
Copy link
Owner

pH-7 commented Aug 10, 2022 •
edited
Loading

Hi @PriscaTan!

Thanks very much for your kind contribution and changes! This is brilliant!
However, do you mind adding a description to your PR explaining the reason of adding “cube” to the calculator and describe a bit the few changes you have done?

Oh, and one more thing, on what Java version have you tested it?
Do you have a screenshot you could share showing this new button and response on the calculator?

Beside of this, everything else looks good 👍

pH-7
pH-7 reviewed Aug 10, 2022
View reviewed changes
src/simplejavacalculatorTest/CalculatorTest.java
@@ -67,6 +67,12 @@ void CalculateMonoSquareTest() {
Assertions.assertEquals(9.0, calculator.calculateMono(Calculator.MonoOperatorModes.square, 3.0));
}

@Test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding a test 💯

@pH-7
Copy link
Owner

pH-7 commented Aug 15, 2022

Let me know if you need any help/assistance @PriscaTan 🙂 Hopefully what I suggested makes sense to you 😀

@pH-7
Copy link
Owner

pH-7 commented Aug 20, 2022

Hey @PriscaTan 👋 let me know if you are still willing to finish this and get your PR merged? If not, I will close it.

@pH-7
Copy link
Owner

pH-7 commented Oct 26, 2022

Hi @PriscaTan, hope you are keeping well! Did you get the chance to see my comments? I'm about to close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pH-7 pH-7 pH-7 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@PriscaTan PriscaTan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PriscaTan @pH-7