Ability to override OpenMRS frontend core version based on frontend customizations file #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuisson
requested changes
Jul 8, 2024
There was a problem hiding this comment.
@corneliouzbett , should we actually set the coreVersion as part of Ozone?
It seems that as such O3 doesn't work as it should.
scripts/openmrs/frontend_assembly/build-openmrs-frontend.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Romain Buisson <rbuisson@users.noreply.github.com>
It makes sense to me why we should tie "coreVersion" with an Ozone release. I believe that providing a mechanism to override, along with a default setting (use bleeding edge This is an O3 issue rather than Ozone. |
corneliouzbett
changed the title
rbuisson
approved these changes
Jul 8, 2024
rbuisson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the OpenMRS Frontend Core version used in the build process to match the version specified in the frontend customizations file, if present.