Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): remove Serialize impls for Identifier types #2651

Merged

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Mar 9, 2024

Serialize can be derived for IdentifierName etc without explicit impl Serialize, as they just need serde to skip some fields. No changes to the JSON output, just a bit simpler.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-ast Area - AST label Mar 9, 2024
Copy link

codspeed-hq bot commented Mar 9, 2024

CodSpeed Performance Report

Merging #2651 will not alter performance

Comparing 03-09-refactor_ast_remove_Serialize_impls_for_Identifier_types (f42fe25) with main (32303b2)

Summary

✅ 29 untouched benchmarks

@ArnaudBarre
Copy link
Contributor

For info TSIndexSignatureName also need to be renamed to Identifier:

Example code: type C = {[key: string]: number}
oxc vs Babel

@overlookmotel
Copy link
Collaborator Author

overlookmotel commented Mar 10, 2024

I've opened a separate issue #2656 for your point above, Arnaud. Should not be hard to fix.

I don't believe it's directly relevant to this PR - does not block merging this if you agree it's a good change, Boshen.

@Boshen Boshen merged commit a01cf9f into main Mar 10, 2024
20 checks passed
@Boshen Boshen deleted the 03-09-refactor_ast_remove_Serialize_impls_for_Identifier_types branch March 10, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants