bug(semantic): AstNode has incorrect ScopeId

[DonIsaac]

playground link

function foo(cb) { cb = function() { function something(a) { cb(1 + a); } register(something); }(); } foo();
//                                                           ^^^^^^^^^ 

To reproduce:

1. get The first read reference for cb (it has a node whose Id is for the above CallExpression)
2. Get the ScopeId pointed to by that Reference
3. Get the node associated with that ScopeId
4. Notice that it's the anonymous function wrapping something, when it should be the something function

[overlookmotel]

Excellent bug-hunting!

I suspect this may have been caused by #4347 (but that's just a guess).

[Dunqing]

2. Get the ScopeId pointed to by that Reference

The reference doesn't store ScopeId. If you mean the ScopeId of the symbol pointed to by this reference, then the node looks correct.

The following scope snapshot was generated by your provided playground's code

---
source: crates/oxc_semantic/tests/main.rs
assertion_line: 112
input_file: crates/oxc_semantic/tests/fixtures/oxc/index.ts
---
[
  {
    "children": [
      {
        "children": [
          {
            "children": [
              {
                "children": [],
                "flag": "ScopeFlags(StrictMode | Function)",
                "id": 3,
                "node": "Function(something)",
                "symbols": [
                  {
                    "flag": "SymbolFlags(FunctionScopedVariable)",
                    "id": 3,
                    "name": "a",
                    "node": "FormalParameter",
                    "references": [
                      {
                        "flag": "ReferenceFlag(Read)",
                        "id": 0,
                        "name": "a",
                        "node_id": 27
                      }
                    ]
                  }
                ]
              }
            ],
            "flag": "ScopeFlags(StrictMode | Function)",
            "id": 2,
            "node": "Function(<anonymous>)",
            "symbols": [
              {
                "flag": "SymbolFlags(FunctionScopedVariable)",
                "id": 2,
                "name": "something",
                "node": "Function(something)",
                "references": [
                  {
                    "flag": "ReferenceFlag(Read)",
                    "id": 0,
                    "name": "something",
                    "node_id": 32
                  }
                ]
              }
            ]
          }
        ],
        "flag": "ScopeFlags(StrictMode | Function)",
        "id": 1,
        "node": "Function(foo)",
        "symbols": [
          {
            "flag": "SymbolFlags(FunctionScopedVariable)",
            "id": 1,
            "name": "cb",
            "node": "FormalParameter",
            "references": [
              {
                "flag": "ReferenceFlag(Write)",
                "id": 0,
                "name": "cb",
                "node_id": 11
              },
              {
                "flag": "ReferenceFlag(Read)",
                "id": 1,
                "name": "cb",
                "node_id": 28
              }
            ]
          }
        ]
      }
    ],
    "flag": "ScopeFlags(StrictMode | Top)",
    "id": 0,
    "node": "Program",
    "symbols": [
      {
        "flag": "SymbolFlags(BlockScopedVariable | Function)",
        "id": 0,
        "name": "foo",
        "node": "Function(foo)",
        "references": [
          {
            "flag": "ReferenceFlag(Read)",
            "id": 0,
            "name": "foo",
            "node_id": 36
          }
        ]
      }
    ]
  }
]