perf(linter): no_shadow_restricted_names only look up name in hashm…

…ap once
oxc-project · Jul 25, 2024 · a6cbaea · a6cbaea
1 parent 6b39374
commit a6cbaea
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs b/crates/oxc_linter/src/rules/eslint/no_shadow_restricted_names.rs
@@ -36,13 +36,6 @@ declare_oxc_lint!(
     correctness
 );
 
-#[inline]
-fn check_and_diagnostic(s: &str, span: Span, ctx: &LintContext) {
-    if PRE_DEFINE_VAR.contains_key(s) {
-        ctx.diagnostic(no_shadow_restricted_names_diagnostic(s, span));
-    }
-}
-
 impl Rule for NoShadowRestrictedNames {
     fn run_once(&self, ctx: &LintContext<'_>) {
         ctx.symbols().iter().for_each(|symbol_id| {
@@ -63,9 +56,13 @@ impl Rule for NoShadowRestrictedNames {
                 }
             }
 
-            check_and_diagnostic(name, ctx.symbols().get_span(symbol_id), ctx);
-            for span in ctx.symbols().get_redeclarations(symbol_id) {
-                check_and_diagnostic(name, *span, ctx);
+            if PRE_DEFINE_VAR.contains_key(name) {
+                let span = ctx.symbols().get_span(symbol_id);
+                ctx.diagnostic(no_shadow_restricted_names_diagnostic(name, span));
+
+                for &span in ctx.symbols().get_redeclarations(symbol_id) {
+                    ctx.diagnostic(no_shadow_restricted_names_diagnostic(name, span));
+                }
             }
         });
     }