ODS design tokens are not aligned with Figma Design Colors #7511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
@kulmann this is ready for review. |
|
This has been superseded by #7862. Thank you very much for your contribution! The topic is not that easy as it looks unfortunately, because of the deep integration of our design system. Hence I figured it would be easier if I take over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Colors need to be double-checked and adjusted, especially in dark mode.
Related Issue
Motivation and Context
How Has This Been Tested?
Demo
https://www.loom.com/share/614baef41ff1436c90ef353db13f804b
This PR was pushed through GitStart, with contributions from @passy4ucj @WajihaNiazi, @hashimaziz46