Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODS design tokens are not aligned with Figma Design Colors #7373

Closed
tbsbdr opened this issue Jul 29, 2022 · 2 comments · Fixed by #7862
Closed

ODS design tokens are not aligned with Figma Design Colors #7373

tbsbdr opened this issue Jul 29, 2022 · 2 comments · Fixed by #7862
Assignees
@tbsbdr @JammingBen
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 29, 2022 •
edited
Loading

Steps to reproduce

Colors need to be double checked and adjusted, especially in dark mode.
needs manual sync between figma colors and design system tokens by @tbsbdr
Link to the Figma file: https://www.figma.com/file/EqAiB1wY7cYaMaitjyzup3/Current-oC-Web-UI-Kit-(WIP)?node-id=109%3A48360

Screenshot 000165@2x

Screenshot 000166@2x

relates to #7353

Expected behaviour

Balance colors according to design

Screenshot 000167@2x
@tbsbdr tbsbdr self-assigned this Jul 29, 2022
@tbsbdr tbsbdr added the Priority:p3-medium Normal priority label Jul 29, 2022
@tbsbdr tbsbdr added the Type:Bug Something isn't working label Jul 29, 2022
@tbsbdr tbsbdr changed the title adjust color scheme / tokens to design ODS design tokens are not aligned with Figma Design Colors Jul 29, 2022
@fschade
Copy link
Collaborator

fschade commented Aug 15, 2022

@tbsbdr can we provide a link to the figma design for contributors? Maybe we should also put the link into our docs or the gh readme to have it more prominent.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Aug 15, 2022

sure, here comes the link to the Figma file / deeplink to colors:

https://www.figma.com/file/EqAiB1wY7cYaMaitjyzup3/Current-oC-Web-UI-Kit-(WIP)?node-id=109%3A48360

@gitstart gitstart mentioned this issue Aug 24, 2022
Closed
@JammingBen JammingBen self-assigned this Oct 25, 2022
This was referenced Oct 25, 2022
Merged
Merged
@micbar micbar mentioned this issue Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbsbdr tbsbdr

@JammingBen JammingBen

Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[full-ci] Align design colors with Figma owncloud/web
3 participants
@tbsbdr @fschade @JammingBen