Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate oc-table-files from ods to web-app-files #6106

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Dec 7, 2021

Description

ods oc-table-files always contained concrete web-app-files logic, to make development more agile and keep things close
oc-table-files was renamed to resource-table and relocated to live in web-app-files from now on.

Related Issue

Motivation and Context

its unnecessarily much work if oc-table-files live in ODS, to have it relocated makes development easier

How Has This Been Tested?

  • unit tests
  • integration tests
  • acceptance tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

Open tasks:

  • remove oc-table-files from ODS

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20712/16/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/20712/54/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:111

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with it if CI is happy 👍

@pascalwengerter
Copy link
Contributor

I'd add the ODS alpha release here before merging so we can be sure there's really no hickup around the component being deleted

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

75.4% 75.4% Coverage
0.3% 0.3% Duplication

@ownclouders
Copy link
Contributor

Results for oC10Basic https://drone.owncloud.com/owncloud/web/20738/12/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:25

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/20738/50/1
The following scenarios passed on retry:

  • webUIMoveFilesFolders/moveFolders.feature:20

@pascalwengerter pascalwengerter merged commit 473350b into master Dec 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the adopt-oc-table-files branch December 8, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants