Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

relocate oc-table-files to web #1817

Merged
merged 2 commits into from
Dec 8, 2021
Merged

relocate oc-table-files to web #1817

merged 2 commits into from
Dec 8, 2021

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Dec 7, 2021

Description

ods oc-table-files always contained concrete web-app-files logic, to make development more agile and keep things close
oc-table-files was removed from ODS and relocated to live in web-app-files from now on.

Related Issue

Motivation and Context

its unnecessarily much work if oc-table-files live in ODS, to have it relocated makes development easier

How Has This Been Tested?

  • unit tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt

Checklist:

  • tests removed

@fschade fschade self-assigned this Dec 7, 2021
@fschade fschade mentioned this pull request Dec 7, 2021
Merged
6 tasks
pascalwengerter
pascalwengerter reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely needs to extract https://github.com/owncloud/owncloud-design-system/blob/d67d299f1e6b3f0fd204e4501836d275b9fdb3ec/src/components/molecules/OcTable/GhostElement/GhostElement.vue

pascalwengerter
pascalwengerter suggested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust

owncloud-design-system/src/components/molecules/OcTable/GhostElement/GhostElement.vue

Line 10 in d67d299

* Please head to the OcTableFiles component (https://owncloud.design/#/oC%20Components/OcTableFiles) for a demo of the Ghost Element.
(docs update regarding ghost element usage), that'd be it from my side. Otherwise LGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kulmann
kulmann approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit 098e1f2 into master Dec 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-table-files branch December 8, 2021 09:21
@dschmidt dschmidt mentioned this pull request Dec 11, 2021
Closed
@pascalwengerter pascalwengerter mentioned this pull request Dec 13, 2021
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees

@fschade fschade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fschade @kulmann @pascalwengerter