-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test verification of TOTP through webui #98
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
========================================
Coverage 62.6% 62.6%
Complexity 57 57
========================================
Files 12 12
Lines 230 230
========================================
Hits 144 144
Misses 86 86 Continue to review full report at Codecov.
|
@karakayasemi Is this the correct method or is there any better way? Or, try it twice? |
@skshetry as far as I understand, your concern is the key change can cause unwanted fails. |
09603d7
to
6d5312a
Compare
tests/acceptance/features/lib/PersonalSecuritySettingsPageWithTOTPEnabled.php
Show resolved
Hide resolved
$verificationMsg, | ||
__METHOD__ . ' The verification msg could not be found' | ||
); | ||
return $verificationMsg->getText() === 'Verified'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return $verificationMsg->getText() === 'Verified'; | |
return ($verificationMsg->getText() === 'Verified'); |
else { | ||
throw new \Exception( | ||
"TOTP Already used." . | ||
"Multiple key generation not supported due to possibility of same key generation." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make shorter
a325bbb
to
c490a9c
Compare
c490a9c
to
9400b95
Compare
This adds a test for verification of two factor key on the webui. Previously, #88 tested for cli command
twofactor_totp
for verification.