Add acceptance tests for occ #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
add-acceptance
branch
from
18febfd
to
3ff0913
Compare
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=========================================
Coverage 60.28% 60.28%
Complexity 52 52
=========================================
Files 11 11
Lines 214 214
=========================================
Hits 129 129
Misses 85 85Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=========================================
Coverage 60.28% 60.28%
Complexity 52 52
=========================================
Files 11 11
Lines 214 214
=========================================
Hits 129 129
Misses 85 85Continue to review full report at Codecov.
|
skshetry
force-pushed
the
add-acceptance
branch
5 times, most recently
from
1cdc2c3
to
85abd9f
Compare
skshetry
changed the title
skshetry
requested review from
individual-it,
dpakach,
paurakhsharma and
phil-davis
skshetry
force-pushed
the
add-acceptance
branch
2 times, most recently
from
d398264
to
10eea5f
Compare
|
👍 |
individual-it
previously approved these changes
Jan 18, 2019
skshetry
changed the title
skshetry
dismissed
individual-it’s stale review
Needs to get requirements regarding exit code
skshetry
force-pushed
the
add-acceptance
branch
from
e023de3
to
9ee0fd6
Compare
skshetry
changed the title
skshetry
force-pushed
the
add-acceptance
branch
from
cab1d63
to
33ed100
Compare
skshetry
commented
Jan 22, 2019
skshetry
force-pushed
the
add-acceptance
branch
from
4e3a885
to
e5dc938
Compare
skshetry
force-pushed
the
add-acceptance
branch
from
e5dc938
to
7599cf7
Compare
individual-it
approved these changes
Jan 23, 2019
skshetry
force-pushed
the
add-acceptance
branch
from
2d24157
to
8362584
Compare
skshetry
force-pushed
the
add-acceptance
branch
from
8362584
to
8c8b4f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
I have invoked a command within the steps. I'll change that if we think that's bad. Currently, we havenot tested with multiple users as this requires webui to login and logout multiple users.