This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
[OcSelect] Fix search for options provided as objects #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
dschmidt
force-pushed
the
bugfix/filter_objects
branch
4 times, most recently
from
2afc98a
to
ff9dcbe
Compare
only add fuse keys property if label ist set
fschade
force-pushed
the
bugfix/filter_objects
branch
from
ff9dcbe
to
e30830f
Compare
|
@dschmidt can you please have a look if this works for you |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yep, works for me. Feel free to merge if you're happy now (I just cannot approve my own PR) |
kulmann
reviewed
Aug 23, 2021
| @@ -179,19 +179,19 @@ describe("OcTableFiles", () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe("resource details", () => { | |||
| test.skip("resource details", () => { | |||
There was a problem hiding this comment.
ah, because they were not enabled before
kulmann
approved these changes
Aug 23, 2021
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made
OcSelect.filtermake use of thelabelprop as the original filter function of vue-select also does, i.e. this is a regression fix for a breaking change introduced in #1521Related Issue
Motivation and Context
This fixes broken search in ownBrander 2.0.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: