Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Introduce search:input event to select, deprecate autocomplete and add OcRecipient #1521

Merged
merged 9 commits into from
Jul 23, 2021
Merged

Introduce search:input event to select, deprecate autocomplete and add OcRecipient #1521

merged 9 commits into from
Jul 23, 2021

Conversation

LukasHirt
Copy link
Contributor

OcSearch can be used with prop :multiple="true" to achieve the same behaviour as our autocomplete and even better with including selected options directly in the select...

image

image

@LukasHirt LukasHirt added the enhancement New feature or request label Jul 22, 2021
@LukasHirt LukasHirt self-assigned this Jul 22, 2021
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pascalwengerter
Copy link
Contributor

License/CLA fails since @paulcod3 has changed his accounts and can't sign in his old account (from which the commit has been cherrypicked). Perhaps best to reset the changes locally and change authors from his old to his new account

pascalwengerter
pascalwengerter reviewed Jul 22, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@kulmann kulmann mentioned this pull request Jul 22, 2021
Closed
@LukasHirt LukasHirt force-pushed the feat/oc-select-autocomplete branch 6 times, most recently from 33d8d01 to ef1d093 Compare July 22, 2021 14:31
pascalwengerter
pascalwengerter suggested changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a lot of what I'm seeing here, small questions about broken/outdated examples and we should be good to go!

src/components/OcSelect.vue Show resolved Hide resolved
src/components/OcAutocomplete.vue Outdated Show resolved Hide resolved
@LukasHirt LukasHirt force-pushed the feat/oc-select-autocomplete branch from 205f7e0 to f851e2b Compare July 23, 2021 08:58
@LukasHirt LukasHirt force-pushed the feat/oc-select-autocomplete branch from f851e2b to 781e67c Compare July 23, 2021 09:04
kulmann
kulmann reviewed Jul 23, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running yarn start I get a lot of deprecation warnings like these DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0., while master looks fine. Can you confirm?

@LukasHirt
Copy link
Contributor Author

I get a lot of deprecation warnings

Yep, some deps have been updated (no major version bump though). As it doesn't break yet anything, I would say let's take care of updating to new functions in a separate PR...

@LukasHirt
Copy link
Contributor Author

LukasHirt commented Jul 23, 2021 •
edited
Loading

Some of them are btw coming from the UIkit... since we're not updating that one anymore due to some breaking changes it might be necessary to either not update Dart Sass to v2, change the decision and invest the effort to update UIkit even though we're going to remove it or finally move forward with sending it into not-in-our-project dependency heaven 🤷

kulmann
kulmann approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have validation for the format of the icon inside the recipient. And the deprecation warnings of the updated dependencies need to be fixed in a separate PR. Rest looks good to me 👍 💪

src/components/OcRecipient/OcRecipient.vue Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.0% 83.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👥

@LukasHirt LukasHirt merged commit fcc860b into master Jul 23, 2021
@LukasHirt LukasHirt deleted the feat/oc-select-autocomplete branch July 23, 2021 13:20
@dschmidt dschmidt mentioned this pull request Aug 21, 2021
Merged
10 tasks
@dschmidt dschmidt mentioned this pull request Sep 5, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@fschade fschade Awaiting requested review from fschade

Assignees

@LukasHirt LukasHirt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LukasHirt @CLAassistant @pascalwengerter @kulmann @lookacat