Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin wopiserver version #4049

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Pin wopiserver version #4049

merged 2 commits into from
Jun 28, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 28, 2022

Description

Pin the cs3org/wopiserver to version 8.3.0

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar requested a review from wkloucek June 28, 2022 07:44
@wkloucek
Copy link
Contributor

@micbar I'd love to enable renovate bot on the owncloud/ocis repo. Then we can get automatic updates of images, too. Dependabot can't do that :-( (dependabot/dependabot-core#390)

Until now, I though sticking with latest is the better alternative to sticking with a most likely outdated version (since there are no automatic updates)

@micbar
Copy link
Contributor Author

micbar commented Jun 28, 2022

yes, but the latest version is broken 😄

wkloucek
wkloucek requested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intend to set the WOPISERVER_DOCKER_TAG?

@micbar micbar requested a review from wkloucek June 28, 2022 08:26
@wkloucek wkloucek merged commit 8d1f70a into master Jun 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the pin-wopiserver branch June 28, 2022 08:42
ownclouders pushed a commit that referenced this pull request Jun 28, 2022
@wkloucek
commit 8d1f70a
e9e4fb1 
Merge: cff7d65 23bc890
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Jun 28 10:42:46 2022 +0200

    Merge pull request #4049 from owncloud/pin-wopiserver

    Pin wopiserver version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micbar @wkloucek