Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Docker compose files #390

Open
greysteil opened this issue Apr 27, 2018 · 38 comments · May be fixed by #1862
Open

Support for Docker compose files #390

greysteil opened this issue Apr 27, 2018 · 38 comments · May be fixed by #1862
Labels
Keep Exempt this from being marked by stalebot L: docker Docker containers T: new-ecosystem Requests for new ecosystems/languages

Comments

@greysteil
Copy link
Contributor

From @armin-joellenbeck on December 23, 2017 9:21

Knowing when new Docker images are published would be helpful when the are used in a Docker compose file too.

Just like #20, with the file docker-compose.yml instead of Dockerfile.

Copied from original issue: dependabot/feedback#66

@greysteil
Copy link
Contributor Author

👍 for this, and should be relatively straightforward. A couple of things I want to get to first, but I'm definitely game for adding this to Dependabot at some point!

@victorcerutti
Copy link

Hi,
This would be a really good addition, is this still going to happen someday ?

Thanks in advance

@greysteil
Copy link
Contributor Author

I hope so, yes! This is another one that @hmarr owns on our side, but he's very busy scaling Dependabot up to 100m repos!

toolmantim added a commit to buildkite/agent that referenced this issue Jun 7, 2019
It currently can't SHA-pin the docker-compose.yml `image` keys, so can't help us achieve reproducible builds (dependabot/dependabot-core#390)
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 6, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 6, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 6, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 6, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 6, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 6, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 7, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 7, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 7, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 10, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 10, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 12, 2019
@stale stale bot added the wontfix label Oct 23, 2019
@bkaid
Copy link

bkaid commented Oct 23, 2019

@stalebot please leave this open - hoping it gets implemented

@stale stale bot removed the wontfix label Oct 23, 2019
@feelepxyz feelepxyz added the T: feature-request Requests for new features label Oct 23, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 25, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 27, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 27, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 28, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 30, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Oct 31, 2019
pedropombeiro pushed a commit to pedropombeiro/dependabot-core that referenced this issue Nov 5, 2019
@ab77
Copy link

ab77 commented Oct 26, 2023

Just buy Renovate already, integrate and call it done people 🤣

@sbe-arg
Copy link

sbe-arg commented Oct 26, 2023

I made this a few months ago as a workaround until is supported by dependabot. https://github.com/sbe-arg/simple-compose-service-updates in case anyone is interested

@powerman
Copy link

I made this a few months ago as a workaround until is supported by dependabot. https://github.com/sbe-arg/simple-compose-service-updates in case anyone is interested

Looks interesting, but these two points sounds too limiting: "compose files must be on your repo root" (complex projects often have several compose files in different dirs) and "requires full registry including default docker.io/…" (no one name images from default registry this way in compose files and requiring this won't work because people will forget to do this because compose itself will work without this and only updates will be broken which is much harder to notice).

@sbe-arg
Copy link

sbe-arg commented Oct 28, 2023

The compose file locations is a very easy fix, noone has requested a path var or a full scan of yaml files in all subdirectories.

The registry names is harder although for docker hub it can be mocked, other registries always have to be specified.

Open issues and ill try to address them. Thats the normal process for open sourcing.

@njfamirm
Copy link

any update?

👍 for this, and should be relatively straightforward. A couple of things I want to get to first, but I'm definitely game for adding this to Dependabot at some point!

@AliMD
Copy link

AliMD commented Dec 24, 2023

whats up?
Any temporary solution after 5 years?! 😢

@banesullivan
Copy link

Any temporary solution

@AliMD, I recommend reading through all of the above comments for a few different workarounds. My comment above is, in my opinion, a fairly robust workaround: #390 (comment)

@mountainash
Copy link

Here's a pointer to the Renovate code that could jump-start a Developer in to making this work on Dependabot.

@njfamirm
Copy link

njfamirm commented Dec 25, 2023

@AliMD, I recommend reading through all of the above comments for a few different workarounds. My comment above is, in my opinion, a fairly robust workaround: #390 (comment)

Thanks, @banesullivan. This can work as a temporary solution.

@njfamirm
Copy link

Here's a pointer to the Renovate code that could jump-start a Developer in to making this work on Dependabot.

@mountainash Thank you, but we currently use Dependabot. Switching to another tool would involve a time investment.

@njfamirm
Copy link

👍 for this, and should be relatively straightforward. A couple of things I want to get to first, but I'm definitely game for adding this to Dependabot at some point!

@greysteil is any plan for support this? or use another tool?

@greysteil
Copy link
Contributor Author

Not sure - I haven't worked on Dependabot for a few years now. @jeffwidman might know?

@jeffwidman
Copy link
Member

Unfortunately I'm also no longer on the Dependabot maintainer team so have no additional insight into this.

@kevinquillen
Copy link

The only solution for me was just using Renovate for everything, either self hosted or as the free GitHub App.

@marchershey
Copy link

So I'm guessing we're all jumping ship and boarding Renovate? :P

@PythonCoderAS
Copy link

Is this still planned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keep Exempt this from being marked by stalebot L: docker Docker containers T: new-ecosystem Requests for new ecosystems/languages
Projects
Status: Planned