Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: Fix LDAP retry handling #2977

Merged
merged 1 commit into from
Jan 18, 2022
Merged

graph: Fix LDAP retry handling #2977

merged 1 commit into from
Jan 18, 2022

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Jan 18, 2022

The reconnect package was missing the retry loop for LDAP Write
Operations (add, delete, mod, modrdn)

Fixes: #2974

The reconnect package was missing the retry loop for LDAP Write
Operations (add, delete, mod, modrdn)

Fixes: owncloud#2974
@rhafer rhafer requested a review from refs January 18, 2022 10:21
@rhafer rhafer self-assigned this Jan 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

19.6% 19.6% Coverage
15.3% 15.3% Duplication

Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, shame that refactoring this retry loop would require reflection, or a very long switch statement. 👍 LGTM

@butonic butonic merged commit c680326 into owncloud:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP reconnection support for Add/Mod/Del
3 participants