Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP reconnection support for Add/Mod/Del #2974

Closed
rhafer opened this issue Jan 17, 2022 · 0 comments · Fixed by #2977
Closed

LDAP reconnection support for Add/Mod/Del #2974

rhafer opened this issue Jan 17, 2022 · 0 comments · Fixed by #2977
Assignees
@rhafer
Labels
Type:Bug

Comments

@rhafer
Copy link
Contributor

rhafer commented Jan 17, 2022

Describe the bug

https://github.com/owncloud/ocis/blob/master/graph/pkg/identity/ldap/reconnect.go is missing the retry/reconnect logic for the add/mod/delete operations. See the search implementation here: https://github.com/owncloud/ocis/blob/master/graph/pkg/identity/ldap/reconnect.go#L41
@rhafer rhafer self-assigned this Jan 17, 2022
rhafer added a commit to rhafer/ocis that referenced this issue Jan 18, 2022
@rhafer
graph: Fix LDAP retry handling
d57d40a 
The reconnect package was missing the retry loop for LDAP Write
Operations (add, delete, mod, modrdn)

Fixes: owncloud#2974
@rhafer rhafer mentioned this issue Jan 18, 2022
Merged
butonic pushed a commit to butonic/ocis that referenced this issue Jan 19, 2022
@rhafer @butonic
graph: Fix LDAP retry handling
f277ccc 
The reconnect package was missing the retry loop for LDAP Write
Operations (add, delete, mod, modrdn)

Fixes: owncloud#2974
@micbar micbar mentioned this issue Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

graph: Fix LDAP retry handling rhafer/ocis
1 participant
@rhafer