Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set english as default language #2465

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Set english as default language #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e72f5a
Set english as default language
jvillafanez Sep 2, 2021
d0cd338
Add changelog entry
jvillafanez Sep 2, 2021
358bc4b
Adjust acceptance test
jvillafanez Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/set-english-default-dropdown.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Set English as default language in the dropdown in the settings page

The language dropdown didn't have a default language selected, and it was showing an empty value. Now it shows English instead.

https://github.com/owncloud/ocis/pull/2465
1 change: 1 addition & 0 deletions settings/pkg/service/v0/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ var languageSetting = settings.Setting_SingleChoiceValue{
},
},
DisplayValue: "English",
Default: true,
},
{
Value: &settings.ListOptionValue{
Expand Down
2 changes: 1 addition & 1 deletion settings/ui/tests/acceptance/features/settings.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Feature: Set user specific settings
Scenario: Check the default settings
Given user "user1" has logged in using the webUI
And the user browses to the settings page
Then the setting "Language" should not have any value
Then the setting "Language" should have value "English"
When the user browses to the files page
Then the files menu should be listed in language "English"

Expand Down