Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set english as default language #2465

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Set english as default language #2465

merged 3 commits into from
Sep 6, 2021

Conversation

jvillafanez
Copy link
Member

Description

Show English as default language in the settings

Related Issue

#2126

Motivation and Context

How Has This Been Tested?

Manually tested in a fresh environment

  1. Login with a user
  2. Check the settings page

English is selected a language

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jvillafanez jvillafanez self-assigned this Sep 2, 2021
@update-docs
Copy link

update-docs bot commented Sep 2, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez jvillafanez mentioned this pull request Sep 2, 2021
Closed
@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

@jvillafanez
Copy link
Member Author

It seems drone needs some kicking... I don't think we need to touch any additional code for the tests.

pascalwengerter
pascalwengerter approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care!

@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

1 similar comment
@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

@pascalwengerter
Copy link
Contributor

Needs a fix in ocis/settings/ui/tests/acceptance/features/settings.feature:16, most probably Then the setting "Language" should have value "English"

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit 2ef33dc into master Sep 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the default_language_english branch September 6, 2021 14:20
ownclouders pushed a commit that referenced this pull request Sep 6, 2021
@jvillafanez
commit 2ef33dc
89347f8 
Author: Juan Pablo Villafañez <jvillafanez@solidgeargroup.com>
Date:   Mon Sep 6 16:20:13 2021 +0200

    Set english as default language (#2465)

    * Set english as default language

    * Add changelog entry

    * Adjust acceptance test
@micbar micbar mentioned this pull request Sep 15, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@jvillafanez jvillafanez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvillafanez @ownclouders @pascalwengerter @refs