Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial /me/drives implementation #2007

Merged
merged 11 commits into from
Jul 8, 2021
Merged

initial /me/drives implementation #2007

merged 11 commits into from
Jul 8, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented May 3, 2021

Inital spaces API, following #1827
requires cs3org/reva#1678

@update-docs
Copy link

update-docs bot commented May 3, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic
Copy link
Member Author

butonic commented May 3, 2021

cc @dragotin

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2021

@butonic
Copy link
Member Author

butonic commented Jul 7, 2021

blocked by reva PR cs3org/reva#1802

butonic and others added 7 commits July 8, 2021 10:04
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
drive.BaseItem.LastModifiedDateTime = &lastModified
}
if space.Quota != nil {
// FIXME use https://github.com/owncloud/open-graph-api and return proper int64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment?

if res.Type == storageprovider.ResourceType_RESOURCE_TYPE_FILE {
driveItem.File = &msgraph.File{
driveItem.File = &msgraph.OpenGraphFile{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment why weird type?

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only cosmetic stuff

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
1.8% 1.8% Duplication

@butonic butonic merged commit 2119d12 into master Jul 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the spaces-api branch July 8, 2021 21:56
ownclouders pushed a commit that referenced this pull request Jul 8, 2021
Merge: a38af18 7a25f2a
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Thu Jul 8 23:56:17 2021 +0200

    Merge pull request #2007 from owncloud/spaces-api

    initial /me/drives implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants