Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] introduce /dav/spaces endpoint && CS3 list spaces implementation (ocis driver only) #1678

Closed
wants to merge 41 commits into from

Conversation

butonic
Copy link
Contributor

@butonic butonic commented May 3, 2021

initial implementation for listing storage spaces

  • currently lists
    • user homes as type personal spaces
    • shares as type share spaces
    • if /spaces dir does not exist in the metadata it will iterate over all nodes to create the spaces for migration
  • create a share space when creating a share
  • create a personal space when creating a home
    • refactor CreateHome
  • generic create space
  • delete share space on unsharing
  • delete personal in deprovisioning a user
    • and all contained shares
  • delete share space on deleting a folder for all children
  • generic delete space
    • share is special because it should not delete the underlying items. Do we need to differentiate between spaces and sub spaces? eg when a user created a new project space from his personal space? or do we move it out of it and really manage it as a dedicated space? Should we manage share spaces in the same way? at least for ocis we could ... would be too theoretical imo.

@update-docs
Copy link

update-docs bot commented May 3, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic
Copy link
Contributor Author

butonic commented May 3, 2021

cc @dragotin

@butonic butonic changed the title [WIP] List spaces [WIP] List spaces (ocis driver only) May 3, 2021
@C0rby C0rby force-pushed the list-spaces branch 2 times, most recently from 697baa8 to 3206890 Compare May 20, 2021 14:23
@C0rby
Copy link
Contributor

C0rby commented May 27, 2021

All method handlers are implemented. I guess the next step is to refactor/deduplicate the code.

butonic and others added 21 commits June 1, 2021 16:05
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Klaas Freitag <kfreitag@owncloud.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic changed the title [WIP] List spaces (ocis driver only) [WIP] introduce /dav/spaces endpoint && CS3 list spaces implementation (ocis driver only) Jun 8, 2021
@butonic
Copy link
Contributor Author

butonic commented Jun 17, 2021

superseded by #1776

@butonic butonic closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants