Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete tracks in music library after "unshare from self" #567

Closed
paulijar opened this issue Jul 7, 2017 · 3 comments
Closed

Obsolete tracks in music library after "unshare from self" #567

paulijar opened this issue Jul 7, 2017 · 3 comments
Labels

Comments

@paulijar
Copy link
Collaborator

paulijar commented Jul 7, 2017

If user A shares an audio file with user B and then unshares it, the track appears and disappears from the B's music library as expected. If, instead, B unshares the audio file shared by A, then the track is left in B's library. The unshared track cannot be played by B though, and if it was used to provide embedded album art, then the album cover image is missing. There is no way for B to get rid of the obsolete track reference, expect by rebuilding the whole music library.

The behavior is as described above with the latest development version of the Music app. With older versions, the obsolete track references used to prevent the music library from loading at all.

@paulijar
Copy link
Collaborator Author

The commit c03de5b together with PR owncloud/core#28337 solves this issue. I'm still considering if there would be some clever way to cleanup the obsolete track references (say, in background task) when working on top of older core which does not have the required fix.

@paulijar
Copy link
Collaborator Author

For Nextcloud, the relevant PR is nextcloud/server#5797.

paulijar added a commit that referenced this issue Dec 10, 2017
…reviously indexed tracks and clean up the obsolete ones

- The checking can be requested by supplying the argument "--clean-obsolete"
- Obsolete tracks may exist in the index if the relevant file/folder has been unshared so that the Music app has not noticed it (#567)
- This checking is rather long running operation in case the music library is extremely large (may take several minutes for a single user). Hence, it cannot happen automatically in the background task but only on request.
@paulijar
Copy link
Collaborator Author

paulijar commented Dec 10, 2017

I added an option --clean-obsolete to the occ command music:scan which can be used to get rid of any obsolete, previously unshared tracks in the music library. This is potentially a heavy-weight operation, and hence, it cannot be run automatically in the background cleanup task.

As the core-side fixes for this issue have been merged both into ownCloud and Nextcloud, and the inconsistent library can now be fixed by the occ tool, I think that this issue has been addressed as well as possible. Closing.

Edit: the mentioned support for the --clean-obsolete switch has been released in the Music app v0.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant