Dispatch event postUnshareFromSelf when the recipient of a share unshares it #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
3. to review
rullzer
approved these changes
Jul 20, 2017
|
looks great, can you please sign the commit? Thanks! |
- This kind of hook signal used to be emitted in the old Share library but it was missing from Share 2.0 Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
paulijar
force-pushed
the
share20-postUnshareFromSelf
branch
from
238906c
to
7c4a15f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5797 +/- ##
=========================================
Coverage ? 53.87%
Complexity ? 22762
=========================================
Files ? 1405
Lines ? 86723
Branches ? 1328
=========================================
Hits ? 46726
Misses ? 39997
Partials ? 0
|
|
@schiessle Right, I forgot that. Now it's signed. |
schiessle
approved these changes
Jul 20, 2017
schiessle
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old Share library, there used to be signal
post_unshareFromSelfemitted when the recipient of a share unshares it. In the Share 2.0 library, this signal is missing, and hence it is impossible for applications to know if file has become unavailable as a result of "unshare from self".This PR adds dispatching of event
OCP\Share::postUnshareFromSelf, and mapping from it to the legacy hook signalpost_unshareFromSelf.This is a port from owncloud/core#28401.