Restrictions & Guest-App dilemma

[felixheidecke]

@pmaier1 and I just looked at the new implementation idea of guests and sharing with existing users if the email address exists and discovered these dilemmata.

E-Mail exists	Restrict sharing to own group	Result
		Create guest, share with guest
✔️		Share with existing user (not guest)
	✔️	💥 Create guest, can't share with guest
✔️	✔️	💥 Can't share with user / can't create guest

@PVince81 @IljaN @michaelstingl @felixboehm @hodyroff … just to name a few who might be interested ;-)

Decision for the version that should be ready for 10.0.1

• Guest app & sharing restriction are mutually exclusive
  • If both are enabled, show a warning in security & setup warnings: "The 'Guests' app and the sharing restriction 'Restrict users to only share with users in their groups' are mutually exclusive. Please disable one of them to be able to use the other."
  • If both are enabled, disable 'Add user (guest)' in the sharing dialog to prevent users creating guests without shares
  • To make restrictions compatible with the guests app we need a second restriction that just applies on the lookup/autocomplete and still allows sharing Add a sharing option to restrict autocompletion for users in different groups core#27849
• Entering a mail address that belongs to an existing user
  • As https://github.com/owncloud/platform/issues/106 was just implemented the guest app should use it to establish a share with the existing user
  • Sending out invitation mail might need to be prevented
  • share by email, resolve existing users by email core#27847

[felixheidecke]

The only logical conclusion that I have is if the sharing restriction is enabled, the guest app will be disabled.

[pmaier1]

Added Decision for the version that should be ready for 10.0.1

[PVince81]

Guest app may not be enabled if the restriction is active + error message in 'Apps' settings

Should be possible by throwing an exception on the server side when enabling and put a message in the exception, but not sure if it will be translated.

When guest app is enabled, disable (API) and grey out the sharing restriction option

Will need some JS hackery, JS code from the guests app that wakes up on the admin page in the right section and finds the checkbox to disable it.

[felixboehm]

Case 4) also covering Case 3)

Restrict sharing to own group: The purpose is to prevent finding existing users (via sharing dialog user search).
So with enabled guest, you can share via email, even if receiver is existing and not part of your groups.

• Rename option to be more specific?
• How is option implemented? Shares not possible - or lookup not possible?

[felixboehm]

I think this code makes no sense: https://github.com/owncloud/core/blob/master/lib/private/Share/Share.php#L730

What would be the use case ?

Need input from PM
@pmaier1

[pmaier1]

Updated my comment #81 (comment) according to discussion with @felixboehm @hodyroff @felixheidecke.

[felixboehm]

Who can provide an update on what was done here for 10.0.1 ?

[PVince81]

Only owncloud/core#27849 was done AFAIK (I just ticked the box)

As for owncloud/core#27847, some use cases seemed to work with @tomneedham's old PR, but not all use cases.

[PVince81]

Sending out invitation mail might need to be prevented

Last I checked this already worked. The backend refused to send an email but no error was shown, needs proper error handling.

[PVince81]

looks like the duplicate email detection doesn't work correctly in all cases: owncloud/core#27847 (comment).

[PVince81]

@felixheidecke can you take care of the other frontend tasks ?