Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a share for an existing mail address should share with that user instead #65

Closed
pmaier1 opened this issue Apr 13, 2017 · 8 comments

Comments

@pmaier1
Copy link
Contributor

pmaier1 commented Apr 13, 2017

  • Creating a share entering a mail address that already exists for a user currently does not work and does not throw an error.
  • It should actually share with the existing user (no guest account creation) and inform the user about it.
  • Best would be to display a message right below the mail input field in the modal saying "The entered e-mail address is assigned to an existing user. Hit 'Share' to share with 'user'.
  • As the address can probably only be checked after sending the form (?!) we might need another solution?

Related to #58. In this case it should just suggest the respective user in the dropdown.

@IljaN @PVince81 @felixheidecke

@PVince81
Copy link
Contributor

I'm not sure it's the responsibility of the guest app to do that.

This basically introduces the concept of "autocomplete by user's email" which should likely be a core feature. Currently you can enter either user id or display name in the share field. We should probably add email address there as well, as long as that one is unique and if allowed by an admin. (some admins might want to disable search by email).

Then once we have this, the guest app doesn't need any modifications: when typing an email address, there will already be a result displayed so the guest app won't show its own "Guest" entry.

@PVince81
Copy link
Contributor

Well, maybe not "autocomplete by user's email" because that implies typing partial email addresses.

Let's reword as: if a user enters a full valid email address in the sharing field and there is a unique user with that email address, then show that user in the selection.

@pmaier1

@pmaier1
Copy link
Contributor Author

pmaier1 commented Apr 13, 2017

Ok, sounds reasonable. Anyway with the current guest app just nothing happens when you hit the button if you entered an existing mail address. At least this is not acceptable for the release.

@PVince81
Copy link
Contributor

Anyway with the current guest app just nothing happens when you hit the button if you entered an existing mail address. At least this is not acceptable for the release.

Agreed, this should be prevented.

@PVince81
Copy link
Contributor

sounds reasonable

new enhancement ticket for core ?

@pmaier1
Copy link
Contributor Author

pmaier1 commented Apr 13, 2017

yes, please ;)

@felixboehm
Copy link
Contributor

Please open a bug ticket in core. Sharing should also work with existing emails.

@felixboehm
Copy link
Contributor

Follow Up #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants