-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a share for an existing mail address should share with that user instead #65
Comments
I'm not sure it's the responsibility of the guest app to do that. This basically introduces the concept of "autocomplete by user's email" which should likely be a core feature. Currently you can enter either user id or display name in the share field. We should probably add email address there as well, as long as that one is unique and if allowed by an admin. (some admins might want to disable search by email). Then once we have this, the guest app doesn't need any modifications: when typing an email address, there will already be a result displayed so the guest app won't show its own "Guest" entry. |
Well, maybe not "autocomplete by user's email" because that implies typing partial email addresses. Let's reword as: if a user enters a full valid email address in the sharing field and there is a unique user with that email address, then show that user in the selection. |
Ok, sounds reasonable. Anyway with the current guest app just nothing happens when you hit the button if you entered an existing mail address. At least this is not acceptable for the release. |
Agreed, this should be prevented. |
new enhancement ticket for core ? |
yes, please ;) |
Please open a bug ticket in core. Sharing should also work with existing emails. |
Follow Up #81 |
Related to #58. In this case it should just suggest the respective user in the dropdown.
@IljaN @PVince81 @felixheidecke
The text was updated successfully, but these errors were encountered: