Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] Exif Description #453

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

0xb0ba
Copy link
Contributor

@0xb0ba 0xb0ba commented Oct 27, 2015

show exif description (if exists) instead filename on preview and slideshow

TODO

Designers need to figure out how to properly show that description.

  • Centred?
  • 3 lines? In this example it would just be the first line over 3 narrower lines
  • Scroller or rollover? Rollover would fill the screen with that description since we have to keep it narrow. Scroller requires 2 additional touch areas instead of an ugly scrollbar

A lot of galleries show the exif data in a side-bar.

default

default

@oparoz
Copy link
Contributor

oparoz commented Oct 27, 2015

Thanks!
We'll first need to discuss if that's something we want to add, but in the meantime, I'll just write down notes about the changes needed before this can be merged.

@jancborchardt and his team can check the design.

'name' => 'files#exif',
'url' => '/files/exif',
'verb' => 'GET'
],
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public routes will need the same endpoint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@oparoz
Copy link
Contributor

oparoz commented Oct 27, 2015

Thanks for the fixes.

How long can descriptions be?
I think you might need to use a different CSS style if we're talking about a paragraph.

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Oct 28, 2015

3 seconds as control. enough to read. then goes out to show the full picture.

@oparoz
Copy link
Contributor

oparoz commented Oct 28, 2015

3 seconds as control. enough to read. then goes out to show the full picture.

Wait, so you mean, this is blocking the rendering of the picture? First the description is shown for 3 seconds, then it's replaced by the image and cannot be seen again?

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Oct 28, 2015

no, no. :) description show over pictures, and may close the necessary detail in the picture...
after hide its may be show by mouse movement.

@oparoz
Copy link
Contributor

oparoz commented Oct 28, 2015

OK, but how big can that description be? If it can be as long as it wants, we may need to limit it to maybe 2 lines and reveal the rest on hover.

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Oct 28, 2015

css already in one line

@oparoz
Copy link
Contributor

oparoz commented Oct 28, 2015

Yes, but that's for the title, so it's not a problem if we're missing 10% of the filename because there isn't enough space, but if we only get one line out of 10 for a description, then it's going to be frustrating for users.

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Oct 29, 2015

Yes you are right. some people may be stored there stories.

@oparoz
Copy link
Contributor

oparoz commented Oct 31, 2015

Can you provide a few samples with stories stored in EXIF data?

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 2, 2015

No I can not. I keep a few words describing the photo.

@oparoz
Copy link
Contributor

oparoz commented Nov 2, 2015

@deMattin @setnes @patman15 Anybody with pictures with EXIF descriptions so that we can properly test this PR?

@jancborchardt
Copy link
Member

@0xb0ba can you post a screenshot of this change so it’s easier to review?

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 2, 2015

default

@oparoz
Copy link
Contributor

oparoz commented Nov 2, 2015

Thanks for that @0xb0ba.

Designers need to figure out how to properly show that description.

  • Centred?
  • 3 lines? In this example it would just be the first line over 3 narrower lines
  • Scroller or rollover? Rollover would fill the screen with that description since we have to keep it narrow. Scroller requires 2 additional touch areas instead of an ugly scrollbar

A lot of galleries show the exif data in a side-bar. I think it would make it easier to show the meta-data we have.

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 2, 2015

@oparoz, I'm not a designer. I can not answer these questions. in most cases it is the description of a few words, scroller or rollover is likely not needed.

exif data need not always. its cool in popup side-bar. description should always, especially in the slideshow.

@jancborchardt
Copy link
Member

I’m not sure we should show it there to be honest. What’s the usecase for exif description like that, I have never seen it really. How do other photo apps approach this?

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 2, 2015

I have never seen it really

for that they need to fill

default

@oparoz
Copy link
Contributor

oparoz commented Nov 2, 2015

Thanks for the screenshot @0xb0ba. What happens on Picasa when you switch to portrait mode?

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 2, 2015

default

@patman15
Copy link

patman15 commented Nov 2, 2015

@oparoz Sorry, I only have loads of pictures with GPS tags but no comments ...

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 2, 2015

@patman15, gps tags its next step :)

@patman15
Copy link

patman15 commented Nov 2, 2015

@0xb0ba, okidoki let me know when it's ready, I can test that. :-)

@oparoz
Copy link
Contributor

oparoz commented Nov 3, 2015

Thanks. That works quite well for landscape pictures shown in portrait mode, but would cover 1/3 of a portrait.

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 3, 2015

It's not a problem. it hides after 3 seconds.

@oparoz
Copy link
Contributor

oparoz commented Nov 3, 2015

The default timer is for the whole interface, so it is a problem when zooming in/out as there is a large block of text masking part of the image.

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 3, 2015

its not problem too - 0xb0ba@add90f0

@0xb0ba
Copy link
Contributor Author

0xb0ba commented Nov 3, 2015

what is the probability that the block will be large?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants