Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename command s3:ls to s3:list #112

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Rename command s3:ls to s3:list #112

merged 1 commit into from
Aug 21, 2018

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Aug 10, 2018 •
edited
Loading

Refrences: #111 (Rename occ command s3:ls to s3:list for better identification)

This PR does two things:

  • renaming the file ls.php --> s3list.php
  • renaming the command from s3:ll --> s3:list

Documentation relevant, will file a doc issue asap

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mmattel mmattel mentioned this pull request Aug 10, 2018
Closed
@mmattel mmattel force-pushed the s3_list branch 2 times, most recently from 55c7eee to 5677d60 Compare August 10, 2018 09:58
@mmattel mmattel mentioned this pull request Aug 11, 2018
Closed
@mmattel mmattel force-pushed the s3_list branch 3 times, most recently from 1714645 to 88385e7 Compare August 20, 2018 08:13
@mmattel
Copy link
Contributor Author

mmattel commented Aug 20, 2018

@DeepDiver1975 @patrickjahns
According your ok on talk, can you review please and merge?

@DeepDiver1975 DeepDiver1975 merged commit e72d5f5 into master Aug 21, 2018
@DeepDiver1975 DeepDiver1975 deleted the s3_list branch August 21, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@patrickjahns patrickjahns Awaiting requested review from patrickjahns

Assignees
No one assigned
Labels
3 - To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmattel @CLAassistant @DeepDiver1975