Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

files_primary_s3: renaming occ command s3:ls to s3:list #4354

Closed
mmattel opened this issue Aug 10, 2018 · 6 comments
Closed

files_primary_s3: renaming occ command s3:ls to s3:list #4354

mmattel opened this issue Aug 10, 2018 · 6 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Aug 10, 2018

Referencing: owncloud/files_primary_s3#112 (Rename command s3:ls to s3:list)

@mmattel mmattel added the occ label Aug 10, 2018
@voroyam voroyam removed their assignment Aug 10, 2018
@voroyam
Copy link
Contributor

voroyam commented Aug 10, 2018

without further info I can not do anything - where is this section? I tried to search occ document and the whole docs, there is no files_primary_s3

omg, why is there already an issue for an PR that is not even in the code yet?

@voroyam
Copy link
Contributor

voroyam commented Aug 10, 2018

I can understand that you, @mmattel , have the goal in mind to raise the documentation of ownCloud to a higher standard.

But for me it feels like you are jumping over the target here. If you create an Issue - that's fine.
If you assign me - I will try to do this issue as soon as possible. If I then notice that I am doing the work for something that is not even there yet, for a unmerged PR, that's not something I want to do.

So please either wait with the assignment, or choose a label that says something like "for future" or "waiting for PR to merge" or create the issue on merge.

@mmattel
Copy link
Contributor Author

mmattel commented Aug 10, 2018

You are right, I missed the label waiting for pr merged...
Just added

@settermjd
Copy link
Contributor

@mmattel, any movement on this?

@mmattel
Copy link
Contributor Author

mmattel commented Aug 20, 2018

yes 😄 the referenced PR is now all green, just waiting for being merged.

Please note that there are two s3: commands that need an occ description:

  • s3:list
  • s3:create-bucket

@mmattel
Copy link
Contributor Author

mmattel commented Aug 28, 2018

Fixed with: #4381
Closing

@mmattel mmattel closed this as completed Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants