Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Skip new and changed tests on old ownCloud10 #37922

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 21, 2020

Description

  1. PR [Tests-Only] Add test scenarios for get all and disabled apps with API #37885 adjusted tests for the Provisioning API "get apps" endpoint. PR List all apps with cloud/apps API endpoint #37901 fixed a problem with the output of that endpoint, so the tests now fail on old ownCloud10 releases. Skip on old releases.

  2. PR redesign ugly, yellow notification center #37875 changed the built-in notifications for the webUI so that "file locked" notifications can be dismissed. The acceptance tests use this, so they now fail on old ownCloud10 releases. Skip on old releases.

This will fix nightly app CI for apps that run the core API tests, e.g. user_ldap, encryption etc.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #37922 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37922   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19408    19408           
=========================================
  Files          1285     1285           
  Lines         75830    75830           
  Branches       1336     1336           
=========================================
  Hits          49101    49101           
  Misses        26335    26335           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19408.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfdb56...c0987ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants