List all apps with cloud/apps API endpoint #37901

phil-davis · 2020-09-11T08:52:04Z

Description

See issue - make the cloud/apps OCS API endpoint really return all apps when no filter is specified.

Related Issue

Fixes cloud/apps endpoint does not report always-enabled-apps in list of all apps #37884

How Has This Been Tested?

CI

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

codecov · 2020-09-11T10:02:25Z

Codecov Report

Merging #37901 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37901   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
- Complexity    19403    19404    +1     
=========================================
  Files          1285     1285           
  Lines         75823    75825    +2     
  Branches       1336     1336           
=========================================
+ Hits          49096    49098    +2     
  Misses        26333    26333           
  Partials        394      394

Flag	Coverage Δ	Complexity Δ
#javascript	`54.06% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.93% <100.00%> (+<0.01%)`	`19404.00 <18.00> (+1.00)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
apps/provisioning_api/lib/Apps.php	`61.76% <100.00%> (ø)`	`11.00 <0.00> (ø)`
lib/private/legacy/app.php	`62.47% <100.00%> (+0.16%)`	`177.00 <18.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ee49a...393fec0. Read the comment docs.

codecov · 2020-09-11T10:12:08Z

Codecov Report

Merging #37901 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37901   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
- Complexity    19403    19404    +1     
=========================================
  Files          1285     1285           
  Lines         75823    75825    +2     
  Branches       1336     1336           
=========================================
+ Hits          49096    49098    +2     
  Misses        26333    26333           
  Partials        394      394

Flag	Coverage Δ	Complexity Δ
#javascript	`54.06% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.93% <100.00%> (+<0.01%)`	`19404.00 <18.00> (+1.00)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
apps/provisioning_api/lib/Apps.php	`61.76% <100.00%> (ø)`	`11.00 <0.00> (ø)`
lib/private/legacy/app.php	`62.47% <100.00%> (+0.16%)`	`177.00 <18.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ee49a...393fec0. Read the comment docs.

codecov · 2020-09-11T10:14:53Z

Codecov Report

Merging #37901 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37901   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
- Complexity    19403    19404    +1     
=========================================
  Files          1285     1285           
  Lines         75823    75825    +2     
  Branches       1336     1336           
=========================================
+ Hits          49096    49098    +2     
  Misses        26333    26333           
  Partials        394      394

Flag	Coverage Δ	Complexity Δ
#javascript	`54.06% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.93% <100.00%> (+<0.01%)`	`19404.00 <18.00> (+1.00)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
apps/provisioning_api/lib/Apps.php	`61.76% <100.00%> (ø)`	`11.00 <0.00> (ø)`
lib/private/legacy/app.php	`62.47% <100.00%> (+0.16%)`	`177.00 <18.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ee49a...393fec0. Read the comment docs.

codecov · 2020-09-11T10:15:54Z

Codecov Report

Merging #37901 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37901   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
- Complexity    19403    19404    +1     
=========================================
  Files          1285     1285           
  Lines         75823    75825    +2     
  Branches       1336     1336           
=========================================
+ Hits          49096    49098    +2     
  Misses        26333    26333           
  Partials        394      394

Flag	Coverage Δ	Complexity Δ
#javascript	`54.06% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.93% <100.00%> (+<0.01%)`	`19404.00 <18.00> (+1.00)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
apps/provisioning_api/lib/Apps.php	`61.76% <100.00%> (ø)`	`11.00 <0.00> (ø)`
lib/private/legacy/app.php	`62.47% <100.00%> (+0.16%)`	`177.00 <18.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ee49a...393fec0. Read the comment docs.

codecov · 2020-09-11T10:17:39Z

Codecov Report

Merging #37901 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37901   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
- Complexity    19403    19404    +1     
=========================================
  Files          1285     1285           
  Lines         75823    75825    +2     
  Branches       1336     1336           
=========================================
+ Hits          49096    49098    +2     
  Misses        26333    26333           
  Partials        394      394

Flag	Coverage Δ	Complexity Δ
#javascript	`54.06% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.93% <100.00%> (+<0.01%)`	`19404.00 <18.00> (+1.00)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
apps/provisioning_api/lib/Apps.php	`61.76% <100.00%> (ø)`	`11.00 <0.00> (ø)`
lib/private/legacy/app.php	`62.47% <100.00%> (+0.16%)`	`177.00 <18.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ee49a...393fec0. Read the comment docs.

codecov · 2020-09-15T09:08:19Z

Codecov Report

Merging #37901 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37901   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
- Complexity    19407    19408    +1     
=========================================
  Files          1285     1285           
  Lines         75826    75828    +2     
  Branches       1336     1336           
=========================================
+ Hits          49099    49101    +2     
  Misses        26333    26333           
  Partials        394      394

Flag	Coverage Δ	Complexity Δ
#javascript	`54.06% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.93% <100.00%> (+<0.01%)`	`19408.00 <18.00> (+1.00)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
apps/provisioning_api/lib/Apps.php	`61.76% <100.00%> (ø)`	`11.00 <0.00> (ø)`
lib/private/legacy/app.php	`62.47% <100.00%> (+0.16%)`	`177.00 <18.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd42bb2...82f2cf3. Read the comment docs.

phil-davis · 2020-09-15T09:08:45Z

@micbar is this a reasonable change?

micbar · 2020-09-15T12:05:27Z

Yes. Who is using that API?

@michaelstingl

michaelstingl · 2020-09-15T12:51:12Z

Yes. Who is using that API?

I'm not aware of this endpoint. I want everything in the capabilities.

phil-davis · 2020-09-15T13:43:27Z

If you have admin privs, you can enable/disable apps, find out app info, and get lists of all/enabled/disabled apps.
It is documented https://doc.owncloud.com/server/admin_manual/configuration/user/user_provisioning_api.html#instruction-set-for-apps

The API acceptance tests use these endpoints ;) (and anyone could be using them) This was noticed only because @individual-it was just trying some Provisioning API requests with curl commands and wondered about the inconsistency in the lists of apps returned.

In the "old" webUI, Settings->Admin->Apps when I click "Show Disabled Apps" it requests to index.php/settings/apps/list?category=disabled so that is using a different "private/old" endpoint.

micbar · 2020-09-16T14:26:35Z

ok, sounds reasonable.

phil-davis added the 2 - Developing label Sep 11, 2020

phil-davis self-assigned this Sep 11, 2020

phil-davis force-pushed the issue-37884 branch from f2dccc3 to 393fec0 Compare September 11, 2020 08:57

owncloud deleted a comment from update-docs bot Sep 11, 2020

phil-davis mentioned this pull request Sep 11, 2020

cloud/apps endpoint does not report always-enabled-apps in list of all apps #37884

Closed

phil-davis force-pushed the issue-37884 branch from 393fec0 to 82f2cf3 Compare September 15, 2020 09:07

phil-davis added 3 - To Review and removed 2 - Developing labels Sep 15, 2020

phil-davis requested a review from micbar September 15, 2020 09:08

phil-davis marked this pull request as ready for review September 15, 2020 09:08

micbar approved these changes Sep 16, 2020

View reviewed changes

List all apps with cloud/apps API endpoint

1a87964

phil-davis force-pushed the issue-37884 branch from 82f2cf3 to 1a87964 Compare September 16, 2020 14:36

phil-davis merged commit dc1962a into master Sep 16, 2020

delete-merged-branch bot deleted the issue-37884 branch September 16, 2020 14:37

phil-davis mentioned this pull request Sep 21, 2020

[Tests-Only] Skip new and changed tests on old ownCloud10 #37922

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List all apps with cloud/apps API endpoint #37901

List all apps with cloud/apps API endpoint #37901

phil-davis commented Sep 11, 2020

codecov bot commented Sep 11, 2020

codecov bot commented Sep 11, 2020

codecov bot commented Sep 11, 2020

codecov bot commented Sep 11, 2020

codecov bot commented Sep 11, 2020

codecov bot commented Sep 15, 2020 •

edited

Loading

phil-davis commented Sep 15, 2020

micbar commented Sep 15, 2020

michaelstingl commented Sep 15, 2020

phil-davis commented Sep 15, 2020 •

edited

Loading

micbar commented Sep 16, 2020

List all apps with cloud/apps API endpoint #37901

List all apps with cloud/apps API endpoint #37901

Conversation

phil-davis commented Sep 11, 2020

Description

Related Issue

How Has This Been Tested?

Types of changes

Checklist:

codecov bot commented Sep 11, 2020

Codecov Report

codecov bot commented Sep 11, 2020

Codecov Report

codecov bot commented Sep 11, 2020

Codecov Report

codecov bot commented Sep 11, 2020

Codecov Report

codecov bot commented Sep 11, 2020

Codecov Report

codecov bot commented Sep 15, 2020 • edited Loading

Codecov Report

phil-davis commented Sep 15, 2020

micbar commented Sep 15, 2020

michaelstingl commented Sep 15, 2020

phil-davis commented Sep 15, 2020 • edited Loading

micbar commented Sep 16, 2020

codecov bot commented Sep 15, 2020 •

edited

Loading

phil-davis commented Sep 15, 2020 •

edited

Loading