-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] Change jakearchibald/es6-promise#2.3.0 to components/es6-promise#v4.2.4 #35627
Conversation
…4 like in master
Codecov Report
@@ Coverage Diff @@
## stable10 #35627 +/- ##
==============================================
+ Coverage 63.91% 64.83% +0.91%
Complexity 20223 20223
==============================================
Files 1294 1294
Lines 77275 77312 +37
Branches 1301 1301
==============================================
+ Hits 49393 50123 +730
+ Misses 27497 26804 -693
Partials 385 385
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35627 +/- ##
==============================================
+ Coverage 63.91% 64.83% +0.91%
Complexity 20223 20223
==============================================
Files 1294 1294
Lines 77275 77312 +37
Branches 1301 1301
==============================================
+ Hits 49393 50123 +730
+ Misses 27497 26804 -693
Partials 385 385
Continue to review full report at Codecov.
|
@DeepDiver1975 @micbar @felixheidecke anyone able to review this? |
…. like in master
Description
This changes from
jakearchibald
tocomponents
and bumps the version.The change to
core\js\core.json
was also made to be likemaster
- it made the JS tests pass.Related Issue
Note:
PR #30026 seems to have done this already in
stable10
merged 2018-01-08But PR #33665 seems to have put back the
jakearchibald
version ofes6-promise
But the diffs of that PR are odd, because it looks like the lines were added, not changed.
Motivation and Context
Make
stable10
likemaster
How Has This Been Tested?
Local
make test-js
CI
Types of changes
Checklist: