Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Change jakearchibald/es6-promise#2.3.0 to components/es6-promise#v4.2.4 #35627

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 24, 2019

…. like in master

Description

This changes from jakearchibald to components and bumps the version.

The change to core\js\core.json was also made to be like master - it made the JS tests pass.

Related Issue

Note:
PR #30026 seems to have done this already in stable10 merged 2018-01-08
But PR #33665 seems to have put back the jakearchibald version of es6-promise
But the diffs of that PR are odd, because it looks like the lines were added, not changed.

Motivation and Context

Make stable10 like master

How Has This Been Tested?

Local make test-js
CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Jun 24, 2019
@phil-davis phil-davis changed the title Change jakearchibald/es6-promise#2.3.0 to components/es6-promise#v4.2.4 [stable10] Change jakearchibald/es6-promise#2.3.0 to components/es6-promise#v4.2.4 Jun 24, 2019
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #35627 into stable10 will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35627      +/-   ##
==============================================
+ Coverage       63.91%   64.83%   +0.91%     
  Complexity      20223    20223              
==============================================
  Files            1294     1294              
  Lines           77275    77312      +37     
  Branches         1301     1301              
==============================================
+ Hits            49393    50123     +730     
+ Misses          27497    26804     -693     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.98% <ø> (+1%) 20223 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
lib/private/DB/AdapterOCI8.php 86.66% <0%> (-6.2%) 4% <0%> (ø)
lib/private/DB/OracleConnection.php 66.66% <0%> (-1.91%) 12% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 85.18% <0%> (-1.61%) 18% <0%> (ø)
apps/dav/lib/CalDAV/CalDavBackend.php 80.65% <0%> (+0.13%) 179% <0%> (ø) ⬇️
apps/dav/lib/CardDAV/CardDavBackend.php 83.48% <0%> (+0.23%) 87% <0%> (ø) ⬇️
lib/private/Share/Share.php 71.61% <0%> (+0.27%) 507% <0%> (ø) ⬇️
lib/private/Files/View.php 86.14% <0%> (+0.3%) 399% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 81.09% <0%> (+0.63%) 0% <0%> (ø) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e7710...58873a5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #35627 into stable10 will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35627      +/-   ##
==============================================
+ Coverage       63.91%   64.83%   +0.91%     
  Complexity      20223    20223              
==============================================
  Files            1294     1294              
  Lines           77275    77312      +37     
  Branches         1301     1301              
==============================================
+ Hits            49393    50123     +730     
+ Misses          27497    26804     -693     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.98% <ø> (+1%) 20223 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
lib/private/DB/AdapterOCI8.php 86.66% <0%> (-6.2%) 4% <0%> (ø)
lib/private/DB/OracleConnection.php 66.66% <0%> (-1.91%) 12% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 85.18% <0%> (-1.61%) 18% <0%> (ø)
apps/dav/lib/CalDAV/CalDavBackend.php 80.65% <0%> (+0.13%) 179% <0%> (ø) ⬇️
apps/dav/lib/CardDAV/CardDavBackend.php 83.48% <0%> (+0.23%) 87% <0%> (ø) ⬇️
lib/private/Share/Share.php 71.61% <0%> (+0.27%) 507% <0%> (ø) ⬇️
lib/private/Files/View.php 86.14% <0%> (+0.3%) 399% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 81.09% <0%> (+0.63%) 0% <0%> (ø) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e7710...58873a5. Read the comment docs.

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 @micbar @felixheidecke anyone able to review this?
And get another "rubbish" backport different resolved between master and stable10

@phil-davis phil-davis merged commit eeaa68c into stable10 Jun 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-js-es6-promise-v4.2.4 branch June 26, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants