Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Change jakearchibald/es6-promise#2.3.0 to components/es6-promise#v4.2.4 like in master #34853

Closed
wants to merge 8 commits into from

Conversation

phil-davis
Copy link
Contributor

Description

This changes from jakearchibald to components and bumps the version.

Motivation and Context

Make stable10 like master

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis
Copy link
Contributor Author

Let's see what CI says about this.

And does anyone know:

Why does stable10 use jakearchibald ?

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/core/16228/87

ReferenceError: Can't find variable: Promise in core/vendor/davclient.js/lib/client.js (line 255)

PhantomJS 2.1.1 (Linux 0.0.0): Executed 985 of 989 (30 FAILED) (skipped 4) (20.08 secs / 19.532 secs) 

There must be something more/different in master that makes this work.

@phil-davis phil-davis changed the title Change jakearchibald/es6-promise#2.3.0 to components/es6-promise#v4.2.4 like in master [stable10] Change jakearchibald/es6-promise#2.3.0 to components/es6-promise#v4.2.4 like in master Mar 20, 2019
@PVince81
Copy link
Contributor

there's also this struggle with master: #30487

@PVince81
Copy link
Contributor

@phil-davis bisect ?

@phil-davis phil-davis force-pushed the stable10-es6-promise-v4.2.4 branch from 589c6ff to 2c3f9ae Compare May 30, 2019 09:00
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #34853 into stable10 will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34853      +/-   ##
==============================================
+ Coverage       64.64%    65.4%   +0.76%     
+ Complexity      20093    19901     -192     
==============================================
  Files            1289     1214      -75     
  Lines           76947    68963    -7984     
  Branches         1300        0    -1300     
==============================================
- Hits            49739    45104    -4635     
+ Misses          26824    23859    -2965     
+ Partials          384        0     -384
Flag Coverage Δ Complexity Δ
#javascript ? ?
#phpunit 65.4% <ø> (-0.39%) 19901 <ø> (-192)
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 0% <0%> (-100%) 2% <0%> (ø)
apps/files_sharing/templates/settings-personal.php 20% <0%> (-80%) 0% <0%> (ø)
lib/private/Encryption/File.php 10.71% <0%> (-75%) 10% <0%> (ø)
apps/encryption/lib/Crypto/Encryption.php 69.69% <0%> (-10.91%) 55% <0%> (ø)
lib/private/Files/Storage/Wrapper/Encryption.php 68.05% <0%> (-8.11%) 156% <0%> (ø)
lib/private/Files/Config/CachedMountInfo.php 65% <0%> (-7.23%) 7% <0%> (+1%)
apps/encryption/lib/Crypto/Crypt.php 81.66% <0%> (-7.09%) 67% <0%> (ø)
apps/encryption/lib/KeyManager.php 76.73% <0%> (-6.94%) 83% <0%> (ø)
apps/files_sharing/lib/AppInfo/Application.php 50.98% <0%> (-6.72%) 17% <0%> (ø)
apps/files_sharing/lib/Activity.php 5.34% <0%> (-2.95%) 97% <0%> (-3%)
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655d4aa...2c3f9ae. Read the comment docs.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #34853 into stable10 will increase coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34853      +/-   ##
==============================================
+ Coverage       63.91%   65.98%   +2.06%     
+ Complexity      20223    20221       -2     
==============================================
  Files            1294     1231      -63     
  Lines           77275    69930    -7345     
  Branches         1301        0    -1301     
==============================================
- Hits            49393    46145    -3248     
+ Misses          27497    23785    -3712     
+ Partials          385        0     -385
Flag Coverage Δ Complexity Δ
#javascript ? ?
#phpunit 65.98% <ø> (+1%) 20221 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.91% <0%> (-9.17%) 74% <0%> (ø)
lib/private/DB/AdapterOCI8.php 86.66% <0%> (-6.2%) 4% <0%> (ø)
lib/private/DB/OracleConnection.php 66.66% <0%> (-1.91%) 12% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 85.18% <0%> (-1.61%) 18% <0%> (ø)
...es_sharing/lib/Controller/Share20OcsController.php 87.41% <0%> (-0.11%) 209% <0%> (-2%)
core/js/oc-dialogs.js
core/js/oc-backbone.js
settings/js/admin-apps.js
core/js/config.js
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e7710...7d3e4fd. Read the comment docs.

@phil-davis phil-davis force-pushed the stable10-es6-promise-v4.2.4 branch 3 times, most recently from 9c80e45 to d573105 Compare June 12, 2019 04:03
@phil-davis
Copy link
Contributor Author

See #35627 for newer PR

@phil-davis phil-davis closed this Jun 24, 2019
@phil-davis phil-davis deleted the stable10-es6-promise-v4.2.4 branch June 24, 2019 05:23
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants